add store flag to cache settings struct#1586
Merged
jinhoonbang merged 4 commits intomainfrom Oct 7, 2025
Merged
Conversation
|
👋 jinhoonbang, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
✅ API Diff Results - No breaking changes |
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
nolag
approved these changes
Oct 7, 2025
nolag
reviewed
Oct 7, 2025
| @@ -15,8 +15,10 @@ const ( | |||
|
|
|||
| // CacheSettings defines cache control options for outbound HTTP requests. | |||
| type CacheSettings struct { | |||
Contributor
There was a problem hiding this comment.
I'm curious, why do we have this struct when there's already one generated from the proto?
Contributor
Author
There was a problem hiding this comment.
this one is used for communication between workflow node and gateway node in case it diverges from proto. turned out to be useful because we made a breaking change in proto but not in this struct by deprecating but not deleting ReadFromCache field
krehermann
approved these changes
Oct 7, 2025
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadFromCacheflag and introducecacheflag to mirror latest changes in chainlink-protos (code)