Skip to content

pkg/settings/cresettings: add global and per-owner WorkflowTriggerRateLimit #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmank88 merged 1 commit into from
Oct 7, 2025
Merged

pkg/settings/cresettings: add global and per-owner WorkflowTriggerRateLimit #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"WorkflowLimit": "200",
"WorkflowRegistrationQueueLimit": "20",
"WorkflowExecutionConcurrencyLimit": "50",
"WorkflowTriggerRateLimit": "200rps:200",
"GatewayUnauthenticatedRequestRateLimit": "100rps:-1",
"GatewayUnauthenticatedRequestRateLimitPerIP": "1rps:-1",
"GatewayIncomingPayloadSizeLimit": "10kb",
Expand All @@ -10,7 +11,8 @@
"ZeroBalancePruningTimeout": "24h0m0s"
},
"PerOwner": {
"WorkflowExecutionConcurrencyLimit": "50"
"WorkflowExecutionConcurrencyLimit": "50",
"WorkflowTriggerRateLimit": "200rps:200"
},
"PerWorkflow": {
"TriggerLimit": "10",
Expand Down Expand Up @@ -40,7 +42,6 @@
"RateLimit": "every30s:3"
},
"LogTrigger": {
"RateLimit": "every10s:-1",
"Limit": "5",
"EventRateLimit": "every6s:10",
"FilterAddressLimit": "5",
Expand Down
3 changes: 2 additions & 1 deletion pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
WorkflowLimit = '200'
WorkflowRegistrationQueueLimit = '20'
WorkflowExecutionConcurrencyLimit = '50'
WorkflowTriggerRateLimit = '200rps:200'
GatewayUnauthenticatedRequestRateLimit = '100rps:-1'
GatewayUnauthenticatedRequestRateLimitPerIP = '1rps:-1'
GatewayIncomingPayloadSizeLimit = '10kb'
Expand All @@ -11,6 +12,7 @@ ZeroBalancePruningTimeout = '24h0m0s'

[PerOwner]
WorkflowExecutionConcurrencyLimit = '50'
WorkflowTriggerRateLimit = '200rps:200'

[PerWorkflow]
TriggerLimit = '10'
Expand Down Expand Up @@ -41,7 +43,6 @@ RateLimit = 'every30s:1'
RateLimit = 'every30s:3'

[PerWorkflow.LogTrigger]
RateLimit = 'every10s:-1'
Limit = '5'
EventRateLimit = 'every6s:10'
FilterAddressLimit = '5'
Expand Down
10 changes: 6 additions & 4 deletions pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ var Default = Schema{
WorkflowLimit: Int(200),
WorkflowRegistrationQueueLimit: Int(20),
WorkflowExecutionConcurrencyLimit: Int(50),
WorkflowTriggerRateLimit: Rate(200, 200),
GatewayUnauthenticatedRequestRateLimit: Rate(rate.Every(time.Second/100), -1),
GatewayUnauthenticatedRequestRateLimitPerIP: Rate(rate.Every(time.Second), -1),
GatewayIncomingPayloadSizeLimit: Size(10 * config.KByte),
Expand All @@ -44,6 +45,7 @@ var Default = Schema{
},
PerOwner: Owners{
WorkflowExecutionConcurrencyLimit: Int(50),
WorkflowTriggerRateLimit: Rate(200, 200),
},
PerWorkflow: Workflows{
TriggerLimit: Int(10),
Expand Down Expand Up @@ -73,9 +75,8 @@ var Default = Schema{
RateLimit: Rate(rate.Every(30*time.Second), 3),
},
LogTrigger: logTrigger{
RateLimit: Rate(rate.Every(10*time.Second), -1), //TODO
Limit: Int(5),
EventRateLimit: Rate(rate.Every(time.Minute/10), 10), // TODO
EventRateLimit: Rate(rate.Every(time.Minute/10), 10),
FilterAddressLimit: Int(5),
FilterTopicsPerSlotLimit: Int(10),
},
Expand All @@ -91,7 +92,7 @@ var Default = Schema{
TargetsLimit: Int(3),
ReportSizeLimit: Size(config.KByte),
EVM: evmChainWrite{
TransactionGasLimit: Uint64(500_000), //TODO
TransactionGasLimit: Uint64(500_000),
},
},
ChainRead: chainRead{
Expand All @@ -106,6 +107,7 @@ type Schema struct {
WorkflowLimit Setting[int] `unit:"{workflow}"`
WorkflowRegistrationQueueLimit Setting[int] `unit:"{workflow}"`
WorkflowExecutionConcurrencyLimit Setting[int] `unit:"{workflow}"`
WorkflowTriggerRateLimit Setting[config.Rate]
GatewayUnauthenticatedRequestRateLimit Setting[config.Rate]
GatewayUnauthenticatedRequestRateLimitPerIP Setting[config.Rate]
GatewayIncomingPayloadSizeLimit Setting[config.Size]
Expand All @@ -121,6 +123,7 @@ type Orgs struct {

type Owners struct {
WorkflowExecutionConcurrencyLimit Setting[int] `unit:"{workflow}"`
WorkflowTriggerRateLimit Setting[config.Rate]
}

type Workflows struct {
Expand Down Expand Up @@ -166,7 +169,6 @@ type httpTrigger struct {
RateLimit Setting[config.Rate]
}
type logTrigger struct {
RateLimit Setting[config.Rate]
Limit Setting[int] `unit:"{trigger}"`
EventRateLimit Setting[config.Rate]
FilterAddressLimit Setting[int] `unit:"{address}"`
Expand Down
Loading