update standard cap initialise to take a struct#1590
Merged
patrickhuie19 merged 6 commits intomainfrom Oct 7, 2025
Merged
Conversation
|
👋 patrickhuie19, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
69735af to
f46f895
Compare
|
f46f895 to
f60b0dc
Compare
f60b0dc to
7f1da62
Compare
jmank88
reviewed
Oct 7, 2025
7f1da62 to
372127a
Compare
jmank88
previously approved these changes
Oct 7, 2025
nolag
approved these changes
Oct 7, 2025
jmank88
approved these changes
Oct 7, 2025
patrickhuie19
added a commit
that referenced
this pull request
Oct 8, 2025
#1597) In #1590, we updated the Initialise iface to accept a struct that can be evolved without making backwards incompatible changes. Now, in order to source orgID for workflows in triggers, we are adding the org resolver service. The org resolver service is currently used in the engine and in the registry syncer to pull org ID at that instant for a given workflow owner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new services to Initialise in the standard capabilities interface is always breaking. By making it a struct, we can make updates a little less painful, and only opt-in the capabilities that need the new service(s).
Capabilities PR: https://github.com/smartcontractkit/capabilities/pull/290
Core PR: smartcontractkit/chainlink#19768
common PR: #1590
Order of operations:
[] get approvals on common, capabilities, core
[ x ] merge common
[ x ] merge core
[ x ] update capabilities to pull in the new core ref
[ x ] update core to reference the new git ref of capabilities