Conversation
✅ API Diff Results - No breaking changes |
jmank88
force-pushed
the
chain-fam-wait
branch
from
ebeebe7 to
b5cf638
Compare
jmank88
commented
Oct 8, 2025
| if err := r.Wait(); err != nil { | ||
| return nil, err | ||
| } | ||
| return r.Service.EVM() |
Contributor
Author
There was a problem hiding this comment.
@archseer I wonder if linters can understand cases like this? The synchronization is a bit indirect, via the serviceCh.
cll-gg
reviewed
Oct 8, 2025
jmank88
force-pushed
the
chain-fam-wait
branch
from
b5cf638 to
59c1236
Compare
vyzaldysanchez
previously approved these changes
Oct 8, 2025
Unheilbar
previously approved these changes
Oct 8, 2025
pavel-raykov
reviewed
Oct 8, 2025
jmank88
force-pushed
the
chain-fam-wait
branch
from
59c1236 to
ebba03b
Compare
ilija42
approved these changes
Oct 8, 2025
pavel-raykov
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Servicefield is initialized async so access must be gated by a call toWait.