From 74de4631f1fa176283cba7595a1aaba83e6ad105 Mon Sep 17 00:00:00 2001 From: Lautaro Fernandez Date: Wed, 8 Oct 2025 12:47:08 -0300 Subject: [PATCH 1/3] CRE-550: adding logtrigger size cap limit --- pkg/settings/cresettings/defaults.json | 3 ++- pkg/settings/cresettings/defaults.toml | 1 + pkg/settings/cresettings/settings.go | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/settings/cresettings/defaults.json b/pkg/settings/cresettings/defaults.json index 9c7e1e53b..ea5a9b90c 100644 --- a/pkg/settings/cresettings/defaults.json +++ b/pkg/settings/cresettings/defaults.json @@ -45,7 +45,8 @@ "Limit": "5", "EventRateLimit": "every6s:10", "FilterAddressLimit": "5", - "FilterTopicsPerSlotLimit": "10" + "FilterTopicsPerSlotLimit": "10", + "EventSizeLimit": "5kb" }, "HTTPAction": { "RateLimit": "every30s:3", diff --git a/pkg/settings/cresettings/defaults.toml b/pkg/settings/cresettings/defaults.toml index 59b2db7f3..1c8bdbca0 100644 --- a/pkg/settings/cresettings/defaults.toml +++ b/pkg/settings/cresettings/defaults.toml @@ -47,6 +47,7 @@ Limit = '5' EventRateLimit = 'every6s:10' FilterAddressLimit = '5' FilterTopicsPerSlotLimit = '10' +EventSizeLimit = '5kb' [PerWorkflow.HTTPAction] RateLimit = 'every30s:3' diff --git a/pkg/settings/cresettings/settings.go b/pkg/settings/cresettings/settings.go index 891a1c78e..b28e0b033 100644 --- a/pkg/settings/cresettings/settings.go +++ b/pkg/settings/cresettings/settings.go @@ -79,6 +79,7 @@ var Default = Schema{ EventRateLimit: Rate(rate.Every(time.Minute/10), 10), FilterAddressLimit: Int(5), FilterTopicsPerSlotLimit: Int(10), + EventSizeLimit: Size(5 * config.KByte), }, HTTPAction: httpAction{ RateLimit: Rate(rate.Every(30*time.Second), 3), @@ -173,6 +174,7 @@ type logTrigger struct { EventRateLimit Setting[config.Rate] FilterAddressLimit Setting[int] `unit:"{address}"` FilterTopicsPerSlotLimit Setting[int] `unit:"{topic}"` + EventSizeLimit Setting[config.Size] } type httpAction struct { RateLimit Setting[config.Rate] From bf91f39a2fc2cb2039e82eed20ae2ad41d12537e Mon Sep 17 00:00:00 2001 From: Juan Lautaro Fernandez Date: Wed, 8 Oct 2025 13:57:21 -0300 Subject: [PATCH 2/3] Update pkg/settings/cresettings/settings.go Co-authored-by: Jordan Krage --- pkg/settings/cresettings/settings.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/settings/cresettings/settings.go b/pkg/settings/cresettings/settings.go index b28e0b033..b8eb33589 100644 --- a/pkg/settings/cresettings/settings.go +++ b/pkg/settings/cresettings/settings.go @@ -172,9 +172,9 @@ type httpTrigger struct { type logTrigger struct { Limit Setting[int] `unit:"{trigger}"` EventRateLimit Setting[config.Rate] + EventSizeLimit Setting[config.Size] FilterAddressLimit Setting[int] `unit:"{address}"` FilterTopicsPerSlotLimit Setting[int] `unit:"{topic}"` - EventSizeLimit Setting[config.Size] } type httpAction struct { RateLimit Setting[config.Rate] From 33bdac319754e1824ef8da92af8955be3e7da3d1 Mon Sep 17 00:00:00 2001 From: Lautaro Fernandez Date: Wed, 8 Oct 2025 13:58:08 -0300 Subject: [PATCH 3/3] sort --- pkg/settings/cresettings/defaults.json | 4 ++-- pkg/settings/cresettings/defaults.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/settings/cresettings/defaults.json b/pkg/settings/cresettings/defaults.json index ea5a9b90c..13403f284 100644 --- a/pkg/settings/cresettings/defaults.json +++ b/pkg/settings/cresettings/defaults.json @@ -44,9 +44,9 @@ "LogTrigger": { "Limit": "5", "EventRateLimit": "every6s:10", + "EventSizeLimit": "5kb", "FilterAddressLimit": "5", - "FilterTopicsPerSlotLimit": "10", - "EventSizeLimit": "5kb" + "FilterTopicsPerSlotLimit": "10" }, "HTTPAction": { "RateLimit": "every30s:3", diff --git a/pkg/settings/cresettings/defaults.toml b/pkg/settings/cresettings/defaults.toml index 1c8bdbca0..56eca5efa 100644 --- a/pkg/settings/cresettings/defaults.toml +++ b/pkg/settings/cresettings/defaults.toml @@ -45,9 +45,9 @@ RateLimit = 'every30s:3' [PerWorkflow.LogTrigger] Limit = '5' EventRateLimit = 'every6s:10' +EventSizeLimit = '5kb' FilterAddressLimit = '5' FilterTopicsPerSlotLimit = '10' -EventSizeLimit = '5kb' [PerWorkflow.HTTPAction] RateLimit = 'every30s:3'