Conversation
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
✅ API Diff Results - No breaking changes |
| }, | ||
| }, | ||
| }) | ||
| require.Equal(t, "Bar", result.GetValue().GetStringValue(), result.GetError()) |
There was a problem hiding this comment.
maybe missing some parent test context, but where does the value "Bar" come from if this is expected to error?
| require.Equal(t, "Bar", result.GetValue().GetStringValue()) | ||
| }) | ||
|
|
||
| t.Run("returns an error when there are invalid UTF-8 bytes", func(t *testing.T) { |
There was a problem hiding this comment.
Can you also add one that shows the SDK returns the right error from the host?
| require.Equal(t, "Bar", result.GetValue().GetStringValue()) | ||
| }) | ||
|
|
||
| t.Run("returns an error when there are invalid UTF-8 bytes", func(t *testing.T) { |
There was a problem hiding this comment.
Tests fail because you didn't implement the STD test for common. This version of it verifies the test can pass. Once you have that, I would implement it in Go's SDK too to ensure assumptions you made are correct about messaging (eg the bar question that Street asked below).
It sucks, but it keeps us from having a circular dependency. I think of Go as the reference implementation, even though it's not with the host, it's good to ensure it passes.
|
This PR is stale because it has been open 30 days with no activity. |
|
This PR has been automatically closed because it has been stale for > 30 days. |
3 participants
Requires
Supports