Skip to content

pkg/settings/limits: prevent double close #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmank88 merged 1 commit into from
Oct 10, 2025
Merged

pkg/settings/limits: prevent double close #1608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/settings/limits/updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (u *updater[N]) updateLoop(cre contexts.CRE) {
var c <-chan time.Time
if u.subFn != nil {
updates, cancelSub = u.subFn(contexts.WithCRE(ctx, cre))
defer cancelSub()
defer func() { cancelSub() }() // extra func wrapper is required to ensure we get the final cancelSub value
// opt: poll now to initialize
} else {
t := services.TickerConfig{}.NewTicker(pollPeriod)
Expand Down
Loading