[PRODCRE-1077] Explicitly mark capabilities as local or remote in CapRegistry#1616
[PRODCRE-1077] Explicitly mark capabilities as local or remote in CapRegistry#1616
Conversation
✅ API Diff Results - No breaking changes |
| // v2 ("NoDAG") capabilities | ||
| map<string, CapabilityMethodConfig> method_configs = 7; | ||
| // if true, the capability won't be callable via don2don | ||
| bool local_only = 8; |
There was a problem hiding this comment.
This field looks like an enum: local_only, don2don, local_only + don2don, (?test_only?). Do you think that boolean will be sufficient? (one more enum advantage that the values will become self explanatory and you won't need to add a clarifying comment everywhere.)
There was a problem hiding this comment.
Not really. You can't disable "local" as every capability adds itself to the local registry by default. It's only about exposing remotely or not.
bolekk
changed the title
vyzaldysanchez
requested review from
krehermann,
pavel-raykov and
vyzaldysanchez
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 96353a7 | Previous: 9a5854c | Ratio |
|---|---|---|---|
BenchmarkKeystore_Sign/nop/in-process |
761.6 ns/op |
374.6 ns/op |
2.03 |
This comment was automatically generated by workflow using github-action-benchmark.
3 participants
No description provided.