feat: Use deterministic marshal for digest hashing - GRPC node auth.#1621
Merged
anirudhwarrier merged 1 commit intomainfrom Oct 17, 2025
Merged
feat: Use deterministic marshal for digest hashing - GRPC node auth.#1621anirudhwarrier merged 1 commit intomainfrom
anirudhwarrier merged 1 commit intomainfrom
Conversation
|
👋 seanwangsmartcontract, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
seanwangsmartcontract
had a problem deploying
to
integration
GitHub Actions
Failure
seanwangsmartcontract
had a problem deploying
to
integration
GitHub Actions
Failure
seanwangsmartcontract
temporarily deployed
to
integration
GitHub Actions
Inactive
✅ API Diff Results - No breaking changes |
anirudhwarrier
approved these changes
Oct 17, 2025
Atrax1
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRODCRE-1085
Purpose
We are seeing intermediate auth failures between WfEngineNodes and billingSerivce.
The issue is the hashing function is non deterministic when the request contains a map, during which the key-ordering is not guaranteed. Go randomizes map iteration order on each marshal.
This PR uses https://pkg.go.dev/google.golang.org/protobuf/proto#MarshalOptions
Golang's proto's native support for deterministic map ordering