INFOPLAT-2963 Wires up Signer for Loop Server#1630
Conversation
product-security-plaid-production
Bot
requested review from
DylanTinianov,
Farber98,
Unheilbar,
amit-momin,
dhaidashenko,
fernandezlautaro,
ilija42,
jmank88,
prashantkumar1982,
silaslenihan and
yashnevatia
|
👋 hendoxc, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
jmank88
left a comment
jmank88
left a comment
There was a problem hiding this comment.
LGTM though this will only cover chain relayers.
|
This PR is stale because it has been open 30 days with no activity. |
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
|
This PR is stale because it has been open 30 days with no activity. |
Hi @jmank88 we've reopened this PR as it fell though the cracks and went stale but its still relevant & needed. Per this comment is there somewhere else we should be wiring up a signer for loop server? |
There is not one general place unfortunately, because we do not have the keystore until some deferred constructor is called like with relayers. However, the capability Initialise method would cover many. We would have to look at each of the others individually. |
There was a problem hiding this comment.
Pull request overview
This PR integrates the Beholder client's signing mechanism by setting up CSA and P2P keystores as signers for authentication header generation in both the relayer and standard capabilities components.
Changes:
- Configured Beholder client to use CSA keystore for signing in the relayer's NewRelayer function
- Configured Beholder client to use P2P keystore for signing in standard capabilities initialization
- Removed trailing whitespace from config file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/loop/internal/relayer/relayer.go | Extracts CSA keystore client and sets it as Beholder's signer before creating new relayer |
| pkg/loop/internal/core/services/capability/standard/standard_capabilities.go | Sets P2P keystore as Beholder's signer during standard capabilities initialization |
| pkg/loop/cmd/loopinstall/config.go | Removes trailing newline for formatting consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
engnke
force-pushed
the
INFOPLAT-2963-beholder-rotating-auth-headers-loop-wire-up
branch
from
81a1030 to
adc4bf7
Compare
I pushed a change to the suggested Initialise method after the keystore is created. I also tried to look around for other usage of the keystore where its being initialized but didn't find any. Could you point me to the others that need to be looked at? ty |
That is fine for now. The other cases likely don't have the keystore wired up yet, and would take a larger effort (but it is probably just products that we don't run as LOOPPs or at all anymore 🤷 ). You got the important ones. |
|
Thanks @chainchad @jmank88 please can you merge? |
jmank88
deleted the
INFOPLAT-2963-beholder-rotating-auth-headers-loop-wire-up
branch
No description provided.