Skip to content

pkg/ratelimit: add SetConfig; pkg/settings/cresettings: remove WorkflowRegistrationQueueLimit #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmank88 merged 1 commit into from
Oct 22, 2025
Merged

pkg/ratelimit: add SetConfig; pkg/settings/cresettings: remove WorkflowRegistrationQueueLimit #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/ratelimit/ratelimiter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,16 @@ func (rl *RateLimiter) AllowVerbose(sender string) (senderAllow bool, globalAllo

return senderLimiter.Allow(), rl.global.Allow()
}

func (rl *RateLimiter) SetConfig(config RateLimiterConfig) {
rl.mu.Lock()
defer rl.mu.Unlock()
rl.config = config
rl.global.SetLimit(rate.Limit(config.GlobalRPS))
rl.global.SetBurst(config.GlobalBurst)

for _, limiter := range rl.perSender {
limiter.SetLimit(rate.Limit(config.PerSenderRPS))
limiter.SetBurst(config.PerSenderBurst)
}
}
5 changes: 2 additions & 3 deletions pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
{
"WorkflowLimit": "200",
"WorkflowRegistrationQueueLimit": "20",
"WorkflowExecutionConcurrencyLimit": "50",
"WorkflowTriggerRateLimit": "200rps:200",
"GatewayUnauthenticatedRequestRateLimit": "100rps:-1",
"GatewayUnauthenticatedRequestRateLimitPerIP": "1rps:-1",
"GatewayUnauthenticatedRequestRateLimit": "100rps:100",
"GatewayUnauthenticatedRequestRateLimitPerIP": "1rps:1",
"GatewayIncomingPayloadSizeLimit": "10kb",
"PerOrg": {
"WorkflowDeploymentRateLimit": "every1m0s:1",
Expand Down
5 changes: 2 additions & 3 deletions pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
WorkflowLimit = '200'
WorkflowRegistrationQueueLimit = '20'
WorkflowExecutionConcurrencyLimit = '50'
WorkflowTriggerRateLimit = '200rps:200'
GatewayUnauthenticatedRequestRateLimit = '100rps:-1'
GatewayUnauthenticatedRequestRateLimitPerIP = '1rps:-1'
GatewayUnauthenticatedRequestRateLimit = '100rps:100'
GatewayUnauthenticatedRequestRateLimitPerIP = '1rps:1'
GatewayIncomingPayloadSizeLimit = '10kb'

[PerOrg]
Expand Down
6 changes: 2 additions & 4 deletions pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,10 @@ var Config Schema

var Default = Schema{
WorkflowLimit: Int(200),
WorkflowRegistrationQueueLimit: Int(20),
WorkflowExecutionConcurrencyLimit: Int(50),
WorkflowTriggerRateLimit: Rate(200, 200),
GatewayUnauthenticatedRequestRateLimit: Rate(rate.Every(time.Second/100), -1),
GatewayUnauthenticatedRequestRateLimitPerIP: Rate(rate.Every(time.Second), -1),
GatewayUnauthenticatedRequestRateLimit: Rate(rate.Every(time.Second/100), 100),
GatewayUnauthenticatedRequestRateLimitPerIP: Rate(rate.Every(time.Second), 1),
GatewayIncomingPayloadSizeLimit: Size(10 * config.KByte),

PerOrg: Orgs{
Expand Down Expand Up @@ -128,7 +127,6 @@ var Default = Schema{

type Schema struct {
WorkflowLimit Setting[int] `unit:"{workflow}"`
WorkflowRegistrationQueueLimit Setting[int] `unit:"{workflow}"`
WorkflowExecutionConcurrencyLimit Setting[int] `unit:"{workflow}"`
WorkflowTriggerRateLimit Setting[config.Rate]
GatewayUnauthenticatedRequestRateLimit Setting[config.Rate]
Expand Down
Loading