Skip to content

feat: use hexString instead of pubkey bytes for error logging. #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anirudhwarrier merged 3 commits into from
Oct 23, 2025
Merged

feat: use hexString instead of pubkey bytes for error logging. #1636

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bc3aec
feat: use hexString instead of pubkey bytes for error logging.
seanwangsmartcontract Oct 22, 2025
f8acf4e
Merge branch 'main' into feat/pubkeyEncode
seanwangsmartcontract Oct 22, 2025
c676734
Merge branch 'main' into feat/pubkeyEncode
seanwangsmartcontract Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/nodeauth/jwt/node_jwt_authenticator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package jwt
import (
"context"
"crypto/ed25519"
"encoding/hex"
"fmt"
"log/slog"

Expand Down Expand Up @@ -62,21 +63,21 @@ func (v *NodeJWTAuthenticator) AuthenticateJWT(ctx context.Context, tokenString
isValid, err := v.nodeAuthProvider.IsNodePubKeyTrusted(ctx, publicKey)
if err != nil {
v.logger.Error("Node validation failed",
"csaPubKey", publicKey,
"csaPubKey", hex.EncodeToString(publicKey),
"error", err,
)
return false, claims, fmt.Errorf("node validation failed: %w", err)
}

if !isValid {
v.logger.Warn("Unauthorized node attempted access",
"csaPubKey", publicKey,
"csaPubKey", hex.EncodeToString(publicKey),
)
return false, claims, fmt.Errorf("unauthorized node: %s", publicKey)
return false, claims, fmt.Errorf("unauthorized node: %s", hex.EncodeToString(publicKey))
}

v.logger.Debug("JWT validation successful",
"csaPubKey", publicKey,
"csaPubKey", hex.EncodeToString(publicKey),
)

return true, claims, nil
Expand Down
Loading