pkg/loop: reinitialise standard capabilities#1638
Merged
Conversation
✅ API Diff Results - No breaking changes |
jmank88
commented
Oct 22, 2025
Contributor
Author
There was a problem hiding this comment.
CCIP does something similar here:
But is able to grab a reference to the client, which are unable to do for the same fundamental reason of there being no constructor.
jmank88
force-pushed
the
CAPPL-1080-reinitialise
branch
from
4c3c5f5 to
ad88ac3
Compare
krehermann
previously approved these changes
Oct 22, 2025
jmank88
force-pushed
the
CAPPL-1080-reinitialise
branch
from
ad88ac3 to
1629bc5
Compare
…e of Dial for reconnect
jmank88
force-pushed
the
CAPPL-1080-reinitialise
branch
from
1629bc5 to
7b38eb2
Compare
jmank88
commented
Oct 27, 2025
| return client, nil | ||
| ctx, cancel := context.WithTimeout(ctx, time.Second) | ||
| defer cancel() | ||
| _, err := client.Info(ctx) // ensure exists by triggering lazy connection with reduced timeout |
Contributor
Author
There was a problem hiding this comment.
It seems important to preserve the fast-fail behavior, but then we want to keep any references that we hand out alive from that point. There may be a more graceful way to do this, like as a NewClientConn option, or alternative method.
krehermann
approved these changes
Oct 28, 2025
ilija42
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CAPPL-1080
Supports: