add isValidationError to http action response for error handling#1650
Merged
jinhoonbang merged 3 commits intomainfrom Oct 29, 2025
Merged
add isValidationError to http action response for error handling#1650jinhoonbang merged 3 commits intomainfrom
jinhoonbang merged 3 commits intomainfrom
Conversation
|
👋 jinhoonbang, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
✅ API Diff Results - No breaking changes |
jmank88
reviewed
Oct 29, 2025
Comment on lines
76
to
77
| IsValidationError bool `json:"isValidationError,omitempty"` // indicates whether the error is a validation error (e.g. blocked HTTP header, blocked IP addresses) | ||
| StatusCode int `json:"statusCode,omitempty"` // HTTP status code |
Contributor
There was a problem hiding this comment.
What makes this new field different from e.g. StatusCode == 400 Bad Request, or 4XX generally?
Contributor
Author
There was a problem hiding this comment.
The distinction is that a StatusCode == 4xx indicates an error response returned from the customer’s endpoint. IsValidationError is a request blocked before it's sent to the customer's endpoint. Let me make the comment more clear here.
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
approved these changes
Oct 29, 2025
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
jinhoonbang
temporarily deployed
to
integration
GitHub Actions
Inactive
jinhoonbang
had a problem deploying
to
integration
GitHub Actions
Failure
krehermann
approved these changes
Oct 29, 2025
jmank88
pushed a commit
that referenced
this pull request
Nov 3, 2025
* add isValidationError flag to http action response for better error handling * improve comments
jmank88
added a commit
that referenced
this pull request
Nov 3, 2025
…) (#1679) * add isValidationError flag to http action response for better error handling * improve comments Co-authored-by: jinhoonbang <jin.bang@smartcontract.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add isValidationError to http action response for error handling