Skip to content

Fix keystore CLI embedding#1761

Merged
connorwstein merged 2 commits into
mainfrom
fix-cli-embedding
Jan 8, 2026
Merged

Fix keystore CLI embedding#1761
connorwstein merged 2 commits into
mainfrom
fix-cli-embedding

Conversation

@connorwstein
Copy link
Copy Markdown
Contributor

@connorwstein connorwstein commented Jan 8, 2026

2 problems trying to embed the keystore CLI in another CLI https://github.com/smartcontractkit/chainlink-ccv/pull/514/files#diff-1eaf102507dc7ff7fa1eb95081337e11c03f57da601dd793f21763033499c324R37:

  • The cmd.Root() call in loadKeystore should be a cmd.Parent() otherwise when embedded it will resolve to the higher level command, when really it should be the immediate parent.
  • (cosmetic) The name of the root command should be "keystore" so that when embedded it can be used like ./myservice keystore list

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 8, 2026

👋 connorwstein, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 8, 2026

✅ API Diff Results - No breaking changes


📄 View full apidiff report

Comment thread keystore/cli/cli.go Outdated
Comment thread keystore/cli/cli.go Outdated
@connorwstein connorwstein added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 7f47b3a Jan 8, 2026
35 of 36 checks passed
@connorwstein connorwstein deleted the fix-cli-embedding branch January 8, 2026 19:08
cawthorne pushed a commit that referenced this pull request Jan 13, 2026
* Fix CLI embedding

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants