ARCH-332 Part 2 KMS ed25519 support#1778
Merged
Merged
Conversation
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
changed the title
connorwstein
changed the title
✅ API Diff Results - No breaking changes |
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
changed the title
product-security-plaid-production
Bot
requested review from
bolekk and
harry-anderson
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
timweri
reviewed
Jan 15, 2026
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
timweri
approved these changes
Jan 15, 2026
krehermann
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package github.com/aws/aws-sdk-go doesn't have support for ed25519 which was added only very recently to KMS (https://aws.amazon.com/about-aws/whats-new/2025/11/aws-kms-edwards-curve-digital-signature-algorithm/), so we have to upgrade to aws-sdk-go-v2.
Tested against a secp and ed25519 kms key in sandbox.