Keystore path helper#1779
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested review from
harry-anderson and
vyzaldysanchez
|
👋 connorwstein, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
commented
Jan 15, 2026
| {segments: []string{"EVM", "TX", "my-key", "//"}, expected: "EVM/TX/my-key"}, | ||
| {segments: []string{"EVM", "TX", "my-key", "///"}, expected: "EVM/TX/my-key"}, | ||
| {segments: []string{"EVM", "TX", "my-key", "////"}, expected: "EVM/TX/my-key"}, | ||
| {segments: []string{"evm", "tx", "my-key"}, expected: "evm/tx/my-key"}, |
Contributor
Author
There was a problem hiding this comment.
lowercasing just for consistency with https://github.com/smartcontractkit/chainlink-evm/blob/develop/pkg/keys/v2/evm_tx.go#L19
✅ API Diff Results - No breaking changes |
timweri
approved these changes
Jan 15, 2026
jmank88
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working with a multi-family keystore realized this helper will be useful (as opposed to using strings lib in client)