Feature flag BaseTrigger retransmit + Add Metrics#1936
Merged
DylanTinianov merged 10 commits intomainfrom Mar 30, 2026
Merged
Conversation
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
|
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
…ontractkit/chainlink-common into base-trigger-retry-config
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
changed the title
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
fernandezlautaro
previously approved these changes
Mar 30, 2026
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
changed the title
fernandezlautaro
approved these changes
Mar 30, 2026
| b.metrics.IncAckError("store_delete_failed") | ||
| return err | ||
| } | ||
| if found { |
Contributor
There was a problem hiding this comment.
sorry, why not just add found to Infow? I.e., Infow(,..., "found", found).
| case hadTriggerBucket && !hadEventKey: | ||
| b.lggr.Infow("base trigger ACK: event id not in in-memory pending map for trigger (may exist only in store; reconciling)", | ||
| "capabilityID", b.capabilityId, "triggerID", triggerId, "eventID", eventId) | ||
| case !hadTriggerBucket: |
Contributor
There was a problem hiding this comment.
similarly, here - can't you just output "hadTriggerBucket", hadTriggerBucket (and other params) in the Infow params?
pavel-raykov
approved these changes
Mar 30, 2026
Contributor
|
This is not how we use feature flags. Please read https://docs.google.com/document/d/1tphbuWwB4vJYcXmBxYcN37Gf25N9RZek78mAm_ajy8E/edit?tab=t.0#heading=h.rmx80rnmopjh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a feature flag for enabling base trigger to retransmit events.