Revert "Reduce Vault batch size (#1937)"#1944
Conversation
This reverts commit 16c179a.
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
📊 API Diff Results
|
There was a problem hiding this comment.
Pull request overview
Reverts a prior change that reduced the Vault OCR plugin batch size limit, restoring the previous default/limit value across the CRE settings schema and its generated default configuration files.
Changes:
- Restores
VaultPluginBatchSizeLimitfrom1back to10in the Go settings schema. - Updates the corresponding golden/defaults outputs (
defaults.toml,defaults.json) to match the schema.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/settings/cresettings/settings.go | Restores the schema default/limit for VaultPluginBatchSizeLimit to 10. |
| pkg/settings/cresettings/defaults.toml | Updates the TOML golden/default value for VaultPluginBatchSizeLimit to 10. |
| pkg/settings/cresettings/defaults.json | Updates the JSON golden/default value for VaultPluginBatchSizeLimit to 10. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit 16c179a.
Requires
Supports