add relay metadata fields for remote capability execution#1948
add relay metadata fields for remote capability execution#1948nadahalli merged 1 commit intotejaswi/tee-attestationfrom
Conversation
✅ API Diff Results -
|
There was a problem hiding this comment.
Pull request overview
Updates the confidential relay JSON-RPC wire types to carry additional execution metadata needed for remote capability execution, keeping the request schema aligned across consumers (e.g., Chainlink and confidential-compute).
Changes:
- Add
owner,execution_id, andreference_idfields toCapabilityRequestParamsforconfidential.capability.execute.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Owner string `json:"owner,omitempty"` | ||
| ExecutionID string `json:"execution_id,omitempty"` | ||
| ReferenceID string `json:"reference_id,omitempty"` |
There was a problem hiding this comment.
CapabilityRequestParams adds owner, execution_id, and reference_id but marks them omitempty. If these are part of the required wire contract for remote capability execution (as SecretsRequestParams already requires owner/execution_id), omitempty can silently drop them when empty, producing an invalid/ambiguous request and making it harder for the relay side to distinguish “missing” vs “present but empty”. Consider removing omitempty (and documenting expected formats like the secrets params), or switching to pointer types if the intent is to make presence/absence explicit.
| Owner string `json:"owner,omitempty"` | |
| ExecutionID string `json:"execution_id,omitempty"` | |
| ReferenceID string `json:"reference_id,omitempty"` | |
| Owner string `json:"owner"` | |
| ExecutionID string `json:"execution_id"` | |
| ReferenceID string `json:"reference_id"` |
* Add teeattestation package for TEE attestation validation * Remove caRootsPEM param from ValidateAttestation ValidateAttestation now always uses the hardcoded AWS Nitro root cert. ValidateAttestationWithRoots is available for testing with fake enclaves that use self-signed CA roots. * Fix lint: errors.New, rename FakeAttestor, nolint for CBOR tags * Fix goimports alignment in CBOR struct tags * Check PCR count before accessing indices * Rename package fake to nitrofake * Merge teeattestation into root module * Use fmt.Sprintf for fixed-format PCR JSON in nitrofake * add relay metadata fields for remote capability execution (#1948) * Remove nitrite from Nitro attestation validation * Run gomodtidy after cbor upgrade --------- Co-authored-by: mchain0 <maciej.wisniewski@smartcontract.com>
Summary
Testing