BaseTrigger Max Retries, send backoffs, and Pre-Ack Handling#1969
Open
DylanTinianov wants to merge 28 commits intomainfrom
Open
BaseTrigger Max Retries, send backoffs, and Pre-Ack Handling#1969DylanTinianov wants to merge 28 commits intomainfrom
DylanTinianov wants to merge 28 commits intomainfrom
Conversation
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
|
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
| } | ||
| cutoff := time.Now().Add(-age) | ||
|
|
||
| recs, err := b.store.List(b.ctx) |
Contributor
There was a problem hiding this comment.
it might be better to have a query just to hit the DB asking for events which have been modified recently, and potentially also parameterize the maxAttempts to it
Contributor
Author
There was a problem hiding this comment.
This can be another clean up PR since this changes the interface and will need to be propagated through
…m/smartcontractkit/chainlink-common into CRE-3248-basetrigger-attempts-max
DylanTinianov
changed the title
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
…ontractkit/chainlink-common into CRE-3248-basetrigger-attempts-max
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
changed the title
…ontractkit/chainlink-common into CRE-3248-basetrigger-attempts-max
…ontractkit/chainlink-common into CRE-3248-basetrigger-attempts-max
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: acf3ecf | Previous: 79eab54 | Ratio |
|---|---|---|---|
BenchmarkKeystore_Sign/nop/in-process |
749.5 ns/op |
354.9 ns/op |
2.11 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.