Closed
Conversation
chainchad
commented
Apr 14, 2026
|
|
||
| - name: Notify Fatal Error | ||
| if: !contains([0,1], steps.changes.outputs.exit_code != '0' ) # Fatal exit code | ||
| if: steps.changes.outcome == 'failure' |
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Oh so I definitely biffed that old logic, but the point here was to catch failures other than 1. So I meant:
Suggested change
| if: steps.changes.outcome == 'failure' | |
| if: !contains([0,1], steps.changes.outputs.exit_code ) # Fatal exit code |
w/o that leftover zero comparison. Does that make sense?
Contributor
Author
There was a problem hiding this comment.
Ah ok, yeah so 0 or 1 are expected and > 1 is a critical failure.
Contributor
Author
|
Will close because it doesn't seem like it's needed but feel free to re-open or merge if desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.