Skip to content

pkg/services: wrap context to prevent mockery race#1988

Merged
jmank88 merged 1 commit intomainfrom
ctx-race
Apr 20, 2026
Merged

pkg/services: wrap context to prevent mockery race#1988
jmank88 merged 1 commit intomainfrom
ctx-race

Conversation

@jmank88
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 commented Apr 20, 2026

This is a reinterpretation of the fix proposed in #1984, in lieu of stretchr/testify#1689 or similar.

When the -race detector is active, we wrap contexts derived from services.StopChan so they don't flag the detector when printed by mockery via %#v.

@jmank88 jmank88 requested a review from Fletch153 April 20, 2026 12:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-common

View full report

@jmank88 jmank88 requested a review from pavel-raykov April 20, 2026 12:52
@jmank88 jmank88 marked this pull request as ready for review April 20, 2026 13:17
@jmank88 jmank88 requested a review from a team as a code owner April 20, 2026 13:17
@jmank88 jmank88 enabled auto-merge April 20, 2026 13:27
@jmank88 jmank88 closed this Apr 20, 2026
auto-merge was automatically disabled April 20, 2026 15:27

Pull request was closed

@jmank88 jmank88 reopened this Apr 20, 2026
@jmank88 jmank88 enabled auto-merge April 20, 2026 16:38
@jmank88 jmank88 closed this Apr 20, 2026
auto-merge was automatically disabled April 20, 2026 16:40

Pull request was closed

@jmank88 jmank88 reopened this Apr 20, 2026
@jmank88
Copy link
Copy Markdown
Contributor Author

jmank88 commented Apr 20, 2026

No changes - just trying to trigger CodeQL...

@jmank88 jmank88 enabled auto-merge April 20, 2026 16:53
@jmank88 jmank88 added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit c51b9c4 Apr 20, 2026
31 of 32 checks passed
@jmank88 jmank88 deleted the ctx-race branch April 20, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants