fix(mcms): check if anvil config is valid after selecting the rpc

Author: gustavogama-cll

.changeset/tough-hoops-bow.md

@@ -0,0 +1,5 @@
+---
+"chainlink-deployments-framework": patch
+---
+
+fix(mcms): check if anvil config is valid after selecting the rpc

engine/cld/environment/anvil.go

@@ -214,16 +214,14 @@ func newAnvilChains(
 				"failed to decode network metadata for chain selector %d: %w", chainSelector, errMeta,
 			)
 		}
-		if err := metadata.AnvilConfig.Validate(); err != nil {
-			lggr.Infof("Excluding chain with ID %d from environment due to failed anvil config validation: %s", chainID, err.Error())
-
-			continue
-		}
-
 		if err := selectPublicRPC(lggr, &metadata, network.ChainSelector, network.RPCs); err != nil {
 			lggr.Infof("Excluding chain with ID %d from environment: %s", chainID, err.Error())
 			continue
 		}
+		if err := metadata.AnvilConfig.Validate(); err != nil {
+			lggr.Infof("Excluding chain with ID %d from environment due to failed anvil config validation: %s", chainID, err.Error())
+			continue
+		}
 
 		// Skip chains that are not included in the address book
 		if _, ok := addressesByChain[chainSelector]; !ok {
@@ -308,7 +306,7 @@ func newAnvilChains(
 func selectPublicRPC(
 	lggr logger.Logger, metadata *cfgnet.EVMMetadata, chainSelector uint64, rpcs []cfgnet.RPC,
 ) error {
-	if isPublicRPC(metadata.AnvilConfig.ArchiveHTTPURL) {
+	if metadata.AnvilConfig.ArchiveHTTPURL != "" && isPublicRPC(metadata.AnvilConfig.ArchiveHTTPURL) {
 		return nil
 	}