Skip to content

rename env#1033

Merged
stackman27 merged 3 commits into
mainfrom
sish/rename
Jun 9, 2026
Merged

rename env#1033
stackman27 merged 3 commits into
mainfrom
sish/rename

Conversation

@stackman27

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fa6e236

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stackman27 stackman27 marked this pull request as ready for review June 9, 2026 15:56
@stackman27 stackman27 requested a review from a team as a code owner June 9, 2026 15:56
Copilot AI review requested due to automatic review settings June 9, 2026 15:56
@stackman27 stackman27 requested a review from ecPablo June 9, 2026 15:57
@cl-sonarqube-production

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends CLD’s Canton auth configuration to support additional legacy environment variable aliases and to make Canton OAuth configuration less brittle in CI by inferring an auth strategy when appropriate.

Changes:

  • Add legacy env var aliases ONCHAIN_CANTON_OKTA_* for Canton OAuth fields (auth_url, client_id, client_secret).
  • Add Canton auth strategy inference logic (primarily to infer client_credentials when OAuth secrets are present and auth_strategy is unset).
  • Add/extend tests and ship a patch changeset describing the behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
engine/cld/config/env/config.go Adds ONCHAIN_CANTON_OKTA_* legacy aliases for Canton OAuth env bindings.
engine/cld/config/env/config_test.go Adds a test verifying legacy Okta env bindings populate CantonConfig.
engine/cld/chains/chains.go Adds cantonEffectiveAuthStrategy and uses it for Canton auth selection.
engine/cld/chains/chains_test.go Adds a test case ensuring client-credentials auth is inferred when strategy is unset.
.changeset/canton-okta-env-bindings.md Documents the patch-level behavior change for legacy env vars and inference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread engine/cld/chains/chains.go
Comment thread engine/cld/config/env/config_test.go
ChrisAmora
ChrisAmora previously approved these changes Jun 9, 2026
ecPablo
ecPablo previously approved these changes Jun 9, 2026
@stackman27 stackman27 dismissed stale reviews from ecPablo and ChrisAmora via fa6e236 June 9, 2026 16:41
@stackman27 stackman27 requested review from ChrisAmora and ecPablo June 9, 2026 16:50
@stackman27 stackman27 added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit f2ff7d3 Jun 9, 2026
27 of 28 checks passed
@stackman27 stackman27 deleted the sish/rename branch June 9, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants