rename env#1033
Conversation
🦋 Changeset detectedLatest commit: fa6e236 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Pull request overview
This PR extends CLD’s Canton auth configuration to support additional legacy environment variable aliases and to make Canton OAuth configuration less brittle in CI by inferring an auth strategy when appropriate.
Changes:
- Add legacy env var aliases
ONCHAIN_CANTON_OKTA_*for Canton OAuth fields (auth_url,client_id,client_secret). - Add Canton auth strategy inference logic (primarily to infer
client_credentialswhen OAuth secrets are present andauth_strategyis unset). - Add/extend tests and ship a patch changeset describing the behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| engine/cld/config/env/config.go | Adds ONCHAIN_CANTON_OKTA_* legacy aliases for Canton OAuth env bindings. |
| engine/cld/config/env/config_test.go | Adds a test verifying legacy Okta env bindings populate CantonConfig. |
| engine/cld/chains/chains.go | Adds cantonEffectiveAuthStrategy and uses it for Canton auth selection. |
| engine/cld/chains/chains_test.go | Adds a test case ensuring client-credentials auth is inferred when strategy is unset. |
| .changeset/canton-okta-env-bindings.md | Documents the patch-level behavior change for legacy env vars and inference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.




No description provided.