Skip to content

Add readAsPartyIds#1040

Merged
stackman27 merged 5 commits into
mainfrom
sish/readAsPartyIds1
Jun 10, 2026
Merged

Add readAsPartyIds#1040
stackman27 merged 5 commits into
mainfrom
sish/readAsPartyIds1

Conversation

@stackman27

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a7c3637

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stackman27 stackman27 marked this pull request as ready for review June 10, 2026 17:02
@stackman27 stackman27 requested a review from a team as a code owner June 10, 2026 17:02
Copilot AI review requested due to automatic review settings June 10, 2026 17:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the mcms dependency to a newer pseudo-version (referenced as a prerequisite for smartcontractkit/mcms#784) and wires the new Canton participant ReadAsPartyIDs field through the CLDF → MCMS Canton chain adapter so downstream MCMS Canton flows can access it.

Changes:

  • Bump github.com/smartcontractkit/mcms to v0.47.1-0.20260610155329-856384f2ce70.
  • Extend the Canton chain adapter mapping to populate mcmscanton.Participant.ReadAsPartyIDs from CLDF participants.
  • Update go.sum accordingly for the new module version and checksums.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
go.mod Updates github.com/smartcontractkit/mcms to the prerequisite version that includes the new API surface.
go.sum Refreshes checksums for the updated mcms pseudo-version.
chain/mcms/adapters/chain_access.go Propagates ReadAsPartyIDs when mapping CLDF Canton participants into MCMS Canton participants.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JohnChangUK
JohnChangUK previously approved these changes Jun 10, 2026
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@stackman27 stackman27 added this pull request to the merge queue Jun 10, 2026
Comment thread go.mod
github.com/smartcontractkit/go-daml v0.0.0-20260604143752-c6f6567940ba
github.com/smartcontractkit/libocr v0.0.0-20260304194147-a03701e2c02e
github.com/smartcontractkit/mcms v0.47.1-0.20260609163952-0b2bf692ba6a
github.com/smartcontractkit/mcms v0.47.1-0.20260610155329-856384f2ce70

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just keep the tag instead of a specific commit here?

Merged via the queue into main with commit 6eebfec Jun 10, 2026
44 of 46 checks passed
@stackman27 stackman27 deleted the sish/readAsPartyIds1 branch June 10, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants