feat: update memory client propose and revoke functionality#542
Merged
Conversation
🦋 Changeset detectedLatest commit: 6518f11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jkongie
force-pushed
the
propose-revoke-updates
branch
3 times, most recently
from
9c27a24 to
d6804e9
Compare
This updates the memory client to correctly handle the propose and revoke functionality to mimic the Job Distributor API. This also introduces a new ID generator for the memory client to differentiate from the UUIDs that are set on the job.
jkongie
force-pushed
the
propose-revoke-updates
branch
from
d6804e9 to
6518f11
Compare
|
jkongie
commented
Oct 27, 2025
Comment on lines
-182
to
192
| // Generate unique IDs | ||
| proposalID := uuid.New().String() | ||
| jobID := uuid.New().String() | ||
|
|
||
| // Create the proposal | ||
| proposal := &jobv1.Proposal{ | ||
| Id: proposalID, | ||
| JobId: jobID, | ||
| Spec: in.GetSpec(), | ||
| Status: jobv1.ProposalStatus_PROPOSAL_STATUS_APPROVED, | ||
| proposal, err := m.upsertProposal(nodeID, in.GetSpec(), in.GetLabels()) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This is all moved into a shared function which can be used for batch proposals as well
DimitriosNaikopoulos
approved these changes
Oct 27, 2025
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.59.0 ### Minor Changes - [#536](#536) [`d35d8de`](d35d8de) Thanks [@jkongie](https://github.com/jkongie)! - JD Memory Client now supports filtering in `ListNodes` - [#542](#542) [`5b3a421`](5b3a421) Thanks [@jkongie](https://github.com/jkongie)! - Aligns MemoryJobDistributor `ProposeJob` and `RevokeJob` to have the same functionality as the JobDistributor service - [#540](#540) [`35d9189`](35d9189) Thanks [@jkongie](https://github.com/jkongie)! - JD Memory Client now supports filtering in `ListJobs` --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the memory client to correctly handle the propose and revoke functionality to mimic the Job Distributor API.
This also introduces a new ID generator for the memory client to differentiate from the UUIDs that are set on the job.