fix(catalog): updates errors in remote implementation#551
Merged
giogam merged 6 commits intoOct 31, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: edc3dc3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ot-return-errors-correctly
|
product-security-plaid-production
Bot
requested a review
from gustavogama-cll
gustavogama-cll
approved these changes
Oct 31, 2025
ajaskolski
approved these changes
Oct 31, 2025
giogam
deleted the
CLD-811/catalog-remote-implementation-does-not-return-errors-correctly
branch
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.60.1 ### Patch Changes - [#553](#553) [`8d6a9f7`](8d6a9f7) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix(mcms): select public rpc for fork tests - [#551](#551) [`cf4de66`](cf4de66) Thanks [@giogam](https://github.com/giogam)! - fix(catalog): updates errors in remote implementation --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadDataStoreFromCatalogshould not produce an error when fetching parts of the datastore for a specific domain environment if no records are returned. The implementation treatsErrAddressRefNotFound,ErrChainMetadataNotFound,ErrContractMetadataNotFound, andErrEnvMetadataNotSetas valid cases of an empty datastore. This is useful when a domain environment has no data during the first execution.However, the remote catalog implementation fails to return
ErrAddressRefNotFound,ErrChainMetadataNotFound,ErrContractMetadataNotFound, andErrEnvMetadataNotSetcorrectly, causingLoadDataStoreFromCatalogto fail when no records are found.