Skip to content

chore: remove root go.mod import from scaffolded domain #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkongie merged 1 commit into from
Nov 5, 2025
Merged

chore: remove root go.mod import from scaffolded domain #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-views-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink-deployments-framework": minor
---

Removes the import of a root `go.mod` from a scaffolded domain
1 change: 0 additions & 1 deletion engine/cld/scaffold/scaffold_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ func Test_ScaffoldDomain(t *testing.T) {
repoName := filepath.Base(filepath.Dir(rootDir))
expectedModuleLine := fmt.Sprintf("module github.com/smartcontractkit/%s/domains/%s", repoName, domKey)
assert.Contains(t, string(goModContent), expectedModuleLine)
assert.Contains(t, string(goModContent), fmt.Sprintf("github.com/smartcontractkit/%s => ../../", repoName))

err = ScaffoldDomain(dom)
require.Error(t, err)
Expand Down
2 changes: 0 additions & 2 deletions engine/cld/scaffold/templates/go.mod.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,4 @@ replace (
github.com/fbsobreira/gotron-sdk => github.com/smartcontractkit/chainlink-tron/relayer/gotron-sdk v0.0.5-0.20250422175525-b7575d96bd4d
// replicating the replace directive on cosmos SDK
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1
// Use the local version of base repo
github.com/smartcontractkit/{{.repo}} => ../../
)
Loading