fix(mcms): check if anvil config is valid after selecting the rpc#565
Conversation
🦋 Changeset detectedLatest commit: 5dcdb88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a validation timing issue in the anvil configuration. The validation was occurring before the RPC URL was selected, causing failures when the ArchiveHTTPURL field was empty. The fix reorders the validation to occur after RPC selection and adds a nil check to prevent errors when the field is initially empty.
- Moved anvil config validation to occur after RPC selection
- Added empty string check before calling
isPublicRPCto handle uninitialized URLs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| engine/cld/environment/anvil.go | Reordered validation logic and added nil check for ArchiveHTTPURL |
| .changeset/tough-hoops-bow.md | Added changeset entry documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gustavogama-cll
deleted the
ggama/fix/check-anvil-config-valid-after-selecting-rpc
branch
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.64.0 ### Minor Changes - [#556](#556) [`0e60a11`](0e60a11) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - feat(mcms): check MCM state before calling SetRoot or Execute ### Patch Changes - [#565](#565) [`ba781b4`](ba781b4) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix(mcms): check if anvil config is valid after selecting the rpc --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
We must validate the anvil config instance after selecting the RPC url, otherwise we get a failure due to the empty ArchiveHTTPURL field.
DPT-277