From 5dcdb881bc1ac0be85b6f2e6590e37b5272ff12e Mon Sep 17 00:00:00 2001 From: Gustavo Gama Date: Tue, 4 Nov 2025 23:31:45 -0300 Subject: [PATCH] fix(mcms): check if anvil config is valid after selecting the rpc --- .changeset/tough-hoops-bow.md | 5 +++++ engine/cld/environment/anvil.go | 12 +++++------- 2 files changed, 10 insertions(+), 7 deletions(-) create mode 100644 .changeset/tough-hoops-bow.md diff --git a/.changeset/tough-hoops-bow.md b/.changeset/tough-hoops-bow.md new file mode 100644 index 000000000..b868c234e --- /dev/null +++ b/.changeset/tough-hoops-bow.md @@ -0,0 +1,5 @@ +--- +"chainlink-deployments-framework": patch +--- + +fix(mcms): check if anvil config is valid after selecting the rpc diff --git a/engine/cld/environment/anvil.go b/engine/cld/environment/anvil.go index 8acda171a..7929f1168 100644 --- a/engine/cld/environment/anvil.go +++ b/engine/cld/environment/anvil.go @@ -214,16 +214,14 @@ func newAnvilChains( "failed to decode network metadata for chain selector %d: %w", chainSelector, errMeta, ) } - if err := metadata.AnvilConfig.Validate(); err != nil { - lggr.Infof("Excluding chain with ID %d from environment due to failed anvil config validation: %s", chainID, err.Error()) - - continue - } - if err := selectPublicRPC(lggr, &metadata, network.ChainSelector, network.RPCs); err != nil { lggr.Infof("Excluding chain with ID %d from environment: %s", chainID, err.Error()) continue } + if err := metadata.AnvilConfig.Validate(); err != nil { + lggr.Infof("Excluding chain with ID %d from environment due to failed anvil config validation: %s", chainID, err.Error()) + continue + } // Skip chains that are not included in the address book if _, ok := addressesByChain[chainSelector]; !ok { @@ -308,7 +306,7 @@ func newAnvilChains( func selectPublicRPC( lggr logger.Logger, metadata *cfgnet.EVMMetadata, chainSelector uint64, rpcs []cfgnet.RPC, ) error { - if isPublicRPC(metadata.AnvilConfig.ArchiveHTTPURL) { + if metadata.AnvilConfig.ArchiveHTTPURL != "" && isPublicRPC(metadata.AnvilConfig.ArchiveHTTPURL) { return nil }