Skip to content

fix(mcms): check if anvil config is valid after selecting the rpc #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavogama-cll merged 1 commit into from
Nov 5, 2025
Merged

fix(mcms): check if anvil config is valid after selecting the rpc #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-hoops-bow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink-deployments-framework": patch
---

fix(mcms): check if anvil config is valid after selecting the rpc
12 changes: 5 additions & 7 deletions engine/cld/environment/anvil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,16 +214,14 @@ func newAnvilChains(
"failed to decode network metadata for chain selector %d: %w", chainSelector, errMeta,
)
}
if err := metadata.AnvilConfig.Validate(); err != nil {
lggr.Infof("Excluding chain with ID %d from environment due to failed anvil config validation: %s", chainID, err.Error())

continue
}

if err := selectPublicRPC(lggr, &metadata, network.ChainSelector, network.RPCs); err != nil {
lggr.Infof("Excluding chain with ID %d from environment: %s", chainID, err.Error())
continue
}
if err := metadata.AnvilConfig.Validate(); err != nil {
lggr.Infof("Excluding chain with ID %d from environment due to failed anvil config validation: %s", chainID, err.Error())
continue
}

// Skip chains that are not included in the address book
if _, ok := addressesByChain[chainSelector]; !ok {
Expand Down Expand Up @@ -308,7 +306,7 @@ func newAnvilChains(
func selectPublicRPC(
lggr logger.Logger, metadata *cfgnet.EVMMetadata, chainSelector uint64, rpcs []cfgnet.RPC,
) error {
if isPublicRPC(metadata.AnvilConfig.ArchiveHTTPURL) {
if metadata.AnvilConfig.ArchiveHTTPURL != "" && isPublicRPC(metadata.AnvilConfig.ArchiveHTTPURL) {
return nil
}

Expand Down