Update Sui MCMS bindings#567
Conversation
🦋 Changeset detectedLatest commit: ea32e93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 JohnChangUK, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Sui MCMS (Multi-Chain Multi-Sig) library bindings to version 0.30.2, addressing issues tracked in the referenced deployment framework PR. The update includes using the newly available DeployerStateObj metadata field that was previously unavailable.
Key changes:
- Updated MCMS library dependency from v0.30.1 to v0.30.2-0.20251105142805-988f5319936f
- Updated chainlink-sui dependency to incorporate the new metadata field
- Removed FIXME comments and properly initialized the deployer state object parameter
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updated mcms and chainlink-sui dependencies to newer versions that support the DeployerStateObj field |
| engine/cld/legacy/cli/mcmsv2/mcms_v2.go | Fixed CCIP entrypoint encoder initialization to use the now-available DeployerStateObj instead of empty string placeholders |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| github.com/smartcontractkit/freeport v0.1.3-0.20250716200817-cb5dfd0e369e | ||
| github.com/smartcontractkit/libocr v0.0.0-20250707144819-babe0ec4e358 | ||
| github.com/smartcontractkit/mcms v0.30.1 | ||
| github.com/smartcontractkit/mcms v0.30.2-0.20251105142805-988f5319936f |
There was a problem hiding this comment.
Please use an actual release instead of pointing to a SHA
JohnChangUK
dismissed stale reviews from ecPablo and huangzhen1997
via
a7a90a4
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jkongie
left a comment
jkongie
left a comment
There was a problem hiding this comment.
Looks good now.
I missed this before but please add a changelog with pnpm changeset add and add this as a minor change.
Once this is done I can approve
Thanks!
Thanks, added |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.65.0 ### Minor Changes - [#568](#568) [`109b6f8`](109b6f8) Thanks [@giogam](https://github.com/giogam)! - feat: adds HMAC authentication support for catalog remote - [#559](#559) [`57ee135`](57ee135) Thanks [@ecPablo](https://github.com/ecPablo)! - Add support to decode proposals that use EIP-1967 proxies - [#562](#562) [`aa38817`](aa38817) Thanks [@jkongie](https://github.com/jkongie)! - Removes the import of a root `go.mod` from a scaffolded domain - [#567](#567) [`d06057a`](d06057a) Thanks [@JohnChangUK](https://github.com/JohnChangUK)! - Sui MCMS upgrade ### Patch Changes - [#530](#530) [`dc2c113`](dc2c113) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix: make config files and chain credentials optional --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Desc
Addressing #560
Update Sui MCMS lib