Skip to content

Extend Geth Confirm Func#570

Merged
skudasov merged 11 commits into
mainfrom
custom-wait-mined-confirmer
Nov 12, 2025
Merged

Extend Geth Confirm Func#570
skudasov merged 11 commits into
mainfrom
custom-wait-mined-confirmer

Conversation

@skudasov

Copy link
Copy Markdown
Contributor

No description provided.

@skudasov skudasov requested a review from a team as a code owner November 12, 2025 07:03
@changeset-bot

changeset-bot Bot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 20f6249

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown

👋 skudasov, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Comment thread chain/evm/provider/confirm_functor.go Outdated
Comment thread chain/evm/provider/confirm_functor.go Outdated
Comment thread chain/evm/provider/confirm_functor.go Outdated

@graham-chainlink graham-chainlink left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread chain/evm/provider/confirm_functor.go Outdated
Comment thread chain/evm/provider/confirm_functor.go Outdated
Comment thread chain/evm/provider/confirm_functor.go
Comment thread chain/evm/provider/confirm_functor.go Outdated
Comment thread chain/evm/provider/confirm_functor.go Outdated
Comment thread chain/evm/provider/ctf_anvil_provider_test.go Outdated
Comment thread .changeset/fresh-bushes-hear.md Outdated
@skudasov skudasov requested a review from jkongie November 12, 2025 10:21
@skudasov skudasov changed the title custom wait mined confirmer Extend Geth Confirm Func Nov 12, 2025
@cl-sonarqube-production

Copy link
Copy Markdown

Comment thread chain/evm/provider/confirm_functor.go

@graham-chainlink graham-chainlink left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skudasov skudasov added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main with commit eb74395 Nov 12, 2025
15 checks passed
@skudasov skudasov deleted the custom-wait-mined-confirmer branch November 12, 2025 12:47
github-merge-queue Bot pushed a commit that referenced this pull request Nov 12, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## chainlink-deployments-framework@0.66.0

### Minor Changes

-
[#571](#571)
[`8db262d`](8db262d)
Thanks [@jkongie](https://github.com/jkongie)! - Bump chain-selectors
package to v1.0.81

### Patch Changes

-
[#570](#570)
[`eb74395`](eb74395)
Thanks [@skudasov](https://github.com/skudasov)! - Adds a new EVM
Confirm Functor which allows the user to specify a custom wait interval
for checking confirmation.
    Example

    ```golang
    		p, err := cldf_evm_provider.NewRPCChainProvider(
    			d.ChainSelector,
    			cldf_evm_provider.RPCChainProviderConfig{
    				DeployerTransactorGen: cldf_evm_provider.TransactorFromRaw(
    					getNetworkPrivateKey(),
    				),
    				RPCs: []rpcclient.RPC{
    					{
    						Name:               "default",
    						WSURL:              rpcWSURL,
    						HTTPURL:            rpcHTTPURL,
    						PreferredURLScheme: rpcclient.URLSchemePreferenceHTTP,
    					},
    				},
    				ConfirmFunctor: cldf_evm_provider.ConfirmFuncGeth(
    					30*time.Second,
// set custom confirm ticker time because Anvil's blocks are instant
    					cldf_evm_provider.WithTickInterval(5*time.Millisecond),
    				),
    			},
    		).Initialize(context.Background())
    ```

---------

Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants