fix: handle ports in regexp used to identify public rpc urls#574
Conversation
🦋 Changeset detectedLatest commit: 91facfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gustavogama-cll
force-pushed
the
ggama/fix-handle-ports-regexp-public-rpc-urls
branch
from
d1fcf22 to
91facfa
Compare
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regular expression pattern used to identify private RPC URLs by adding support for optional port numbers. Previously, URLs with explicit ports (e.g., :4443, :9443) were incorrectly classified as public RPCs.
Key changes:
- Updated the
privateRpcRegexppattern to handle optional port numbers using(?::\d+)? - Added test cases for URLs with port numbers to prevent regression
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| engine/cld/environment/anvil.go | Modified regexp pattern to match private RPC URLs with optional port numbers |
| engine/cld/environment/anvil_test.go | Added test cases for private RPC URLs containing port numbers |
| .changeset/purple-bears-peel.md | Added changeset documentation for the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
gustavogama-cll
deleted the
ggama/fix-handle-ports-regexp-public-rpc-urls
branch
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.66.1 ### Patch Changes - [#574](#574) [`2077cd6`](2077cd6) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix: handle ports in regexp used to identify public rpc urls --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
No description provided.