Skip to content

fix: handle ports in regexp used to identify public rpc urls #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavogama-cll merged 1 commit into from
Nov 13, 2025
Merged

fix: handle ports in regexp used to identify public rpc urls #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/purple-bears-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink-deployments-framework": patch
---

fix: handle ports in regexp used to identify public rpc urls
2 changes: 1 addition & 1 deletion engine/cld/environment/anvil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ func selectPublicRPC(
return fmt.Errorf("no public RPCs found for chain %d", chainSelector)
}

var privateRpcRegexp = regexp.MustCompile(`^https?://(rpcs|gap\-.*\.(prod|stage))\.cldev\.sh/`)
var privateRpcRegexp = regexp.MustCompile(`^https?://(rpcs|gap\-.*\.(prod|stage))\.cldev\.sh(?::\d+)?/`)

func isPublicRPC(url string) bool {
return !privateRpcRegexp.MatchString(url)
Expand Down
2 changes: 2 additions & 0 deletions engine/cld/environment/anvil_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ func Test_isPublicRPC(t *testing.T) {
{"https://gap-grpc-job-distributor.public.main.stage.cldev.sh/", false},
{"https://gap-ws-job-distributor.public.main.stage.cldev.sh/", false},
{"https://gap-grpc-chainlink-catalog.public.main.stage.cldev.sh/", false},
{"https://gap-rpc-proxy.public.main.prod.cldev.sh:4443/ethereum/sepolia/archive", false},
{"https://gap-rpc-proxy.public.main.prod.cldev.sh:9443/ethereum/sepolia/archive", false},
{"", true},
{"http://", true},
{"https://", true},
Expand Down
Loading