Skip to content

NONEVM-2403: Pass through mylocalton configs#580

Merged
jadepark-dev merged 13 commits into
mainfrom
ton/bump-mylocalton
Nov 18, 2025
Merged

NONEVM-2403: Pass through mylocalton configs#580
jadepark-dev merged 13 commits into
mainfrom
ton/bump-mylocalton

Conversation

@jadepark-dev

Copy link
Copy Markdown
Contributor

For bumping TON localnet version w/o updating frameworks smartcontractkit/chainlink-ton#373

  • Added configurations for CTFv2, that can be set by caller
  • Support ton api client interface

@changeset-bot

changeset-bot Bot commented Nov 17, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3d95bd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jadepark-dev jadepark-dev marked this pull request as ready for review November 17, 2025 19:17
@jadepark-dev jadepark-dev requested review from a team as code owners November 17, 2025 19:17
Copilot AI review requested due to automatic review settings November 17, 2025 19:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable parameters for TON localnet deployments to support version updates without framework modifications. The changes enable callers to customize the Docker image, retry counts, and environment variables for the CTF (Chainlink Testing Framework) TON provider.

Key changes:

  • Added RetryCount configuration option with a default of 5 retries for API client operations
  • Added Docker image configuration with validation to ensure only supported mylocalton-docker images are used
  • Changed TON API client from concrete type to interface (APIClientWrapped) to support retry wrapper functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
chain/ton/ton_chain.go Added retry count constant and changed Client field type to interface
chain/ton/provider/rpc_provider.go Added retry count configuration and helper method for RPC provider
chain/ton/provider/rpc_provider_test.go Added test coverage for retry count logic, constructor, and validation
chain/ton/provider/ctf_provider.go Added image, retry count, and custom environment configurations for CTF provider
chain/ton/provider/ctf_provider_test.go Added test coverage for image configuration helper
.changeset/good-cups-invite.md Added changeset entry for the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread chain/ton/provider/ctf_provider.go Outdated
@gustavogama-cll gustavogama-cll removed the request for review from kalverra November 17, 2025 19:29
Comment thread chain/ton/ton_chain.go Outdated
Comment thread chain/ton/provider/ctf_provider.go
Comment thread chain/ton/provider/ctf_provider.go Outdated
Copilot AI review requested due to automatic review settings November 18, 2025 11:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread chain/ton/provider/ctf_provider.go
Comment thread chain/ton/provider/ctf_provider.go
Comment on lines +32 to +37
// Only images from this repository are supported.
DefaultTONImage = "ghcr.io/neodix42/mylocalton-docker:v3.7"

// SupportedTONImageRepository is the only supported Docker image repository for TON localnet.
SupportedTONImageRepository = "ghcr.io/neodix42/mylocalton-docker"
)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be private in case it gets referenced outside of this repo

Suggested change
// Only images from this repository are supported.
DefaultTONImage = "ghcr.io/neodix42/mylocalton-docker:v3.7"
// SupportedTONImageRepository is the only supported Docker image repository for TON localnet.
SupportedTONImageRepository = "ghcr.io/neodix42/mylocalton-docker"
)
// Only images from this repository are supported.
defaultTONImage = "ghcr.io/neodix42/mylocalton-docker:v3.7"
// SupportedTONImageRepository is the only supported Docker image repository for TON localnet.
supportedTONImageRepository = "ghcr.io/neodix42/mylocalton-docker"
)

Copilot AI review requested due to automatic review settings November 18, 2025 12:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jadepark-dev jadepark-dev added this pull request to the merge queue Nov 18, 2025
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
76.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Merged via the queue into main with commit 0baab99 Nov 18, 2025
15 of 16 checks passed
@jadepark-dev jadepark-dev deleted the ton/bump-mylocalton branch November 18, 2025 12:23
github-merge-queue Bot pushed a commit that referenced this pull request Nov 18, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## chainlink-deployments-framework@0.67.0

### Minor Changes

-
[#573](#573)
[`f7a31c2`](f7a31c2)
Thanks [@DimitriosNaikopoulos](https://github.com/DimitriosNaikopoulos)!
- add grpc keepalive, retries and connection closure functionality

-
[#580](#580)
[`0baab99`](0baab99)
Thanks [@jadepark-dev](https://github.com/jadepark-dev)! - expose TON
CTF configs to caller

-
[#577](#577)
[`a1074b1`](a1074b1)
Thanks [@jkongie](https://github.com/jkongie)! - Updates `go-ethereum`
to v1.16.7

-
[#579](#579)
[`5d15395`](5d15395)
Thanks [@giogam](https://github.com/giogam)! - feat: adds 'all'
datastore config option

---------

Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants