Update fund nodes cmd#595
Conversation
🦋 Changeset detectedLatest commit: 5606925 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 finleydecker, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR updates the evm nodes fund command to improve usability by accepting ETH values instead of wei and adding newline formatting to output messages.
Key changes:
- Modified the
--amountparameter to accept ETH values instead of wei, with automatic conversion to wei internally - Added newline characters (
\n) toPrintfstatements for better output formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
oh @finleydecker there is an existing issue right now causing the test to fail , the CTF team will be coming up with a fix hopefully soon, else i might have to fix the test manually. This change is not urgent right? |
No, not urgent. Can wait on the fix! |
jkongie
left a comment
jkongie
left a comment
There was a problem hiding this comment.
Please update the .changeset file with more detailed explanation
|
okay i merged in the fix for the failin test, please rebase with the latest |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.68.2 ### Patch Changes - [#588](#588) [`d1febae`](d1febae) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix(mcms): make proposalContextProvider a required param of BuildMCMSv2Cmd - [#595](#595) [`95f96d9`](95f96d9) Thanks [@finleydecker](https://github.com/finleydecker)! - Added -eth flag to the evm nodes fund command. Example: users can now use "-eth 10" to fund nodes up to 10 eth. Also added a new line separator to the current balance log to improve readability. - [#594](#594) [`5936b3b`](5936b3b) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix(mcms): improve error handling in confirmTransaction --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.