fix(engine/test): default SUI image to CTF Provider#598
Conversation
🦋 Changeset detectedLatest commit: 89bfabb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 FelixFan1992, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR updates the Sui devnet Docker container image to a specific versioned release (v1.61.0) instead of using the latest devnet tag.
- Updated the Sui container image from
mysten/sui-tools:devnettomysten/sui-tools:devnet-v1.61.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| var ( | ||
| suiContainerImage = "mysten/sui-tools:devnet" | ||
| suiContainerImage = "mysten/sui-tools:devnet-v1.61.0" |
There was a problem hiding this comment.
i think maybe we should just delete Image: &suiContainerImage, line 37, then the default will fallback to the NewCTFChainProvider which is using devnet-v1.61.0, same with suiContainerPlatform
There was a problem hiding this comment.
Pushed a commit for this change
Instead of setting another image in the test engine layer, we just fallback to the default image set in the CTF provider for SUI so we dont have to maintain another value.
graham-chainlink
changed the title
| testPrivateKey := hex.EncodeToString(seed) // 64 hex chars | ||
|
|
||
| var ( | ||
| suiContainerImage = "mysten/sui-tools:devnet" |
There was a problem hiding this comment.
if we dont set the value here, it falls back to the default value for CTF provider which is the same as the current value set here, so this bit is redundant.
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.68.1 ### Patch Changes - [#596](#596) [`2d45dcc`](2d45dcc) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix: set sui default image to mysten/sui-tools:devnet-v1.61.0 - [#598](#598) [`c38ded5`](c38ded5) Thanks [@FelixFan1992](https://github.com/FelixFan1992)! - fix(engine/test): default SUI image to CTF Provider --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Instead of setting another image in the test engine layer, we just fallback to the default image set in the CTF provider for SUI so we dont have to maintain another value.