chore: bump go to 1.26#980
Conversation
Bumps the Go version to 1.26.2 and updates dependencies
🦋 Changeset detectedLatest commit: c7c1ef5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -130,8 +130,6 @@ func LoadFork( | |||
| if err != nil { | |||
| if errors.Is(err, offchain.ErrEndpointsRequired) { | |||
| lggr.Warn("Skipping JD initialization: gRPC endpoint is not set in config") | |||
| argArr := make([]byte, argArrTyp.Len()) | ||
| for i := range argArrTyp.Len() { | ||
| argArr[i] = byte(argArrTyp.Index(i).Uint()) | ||
| argArr[i] = byte(argArrTyp.Index(i).Uint()) //nolint:gosec // value is always in byte range from ABI decoding |
There was a problem hiding this comment.
Pull request overview
This PR updates Go/tooling versions, dependency versions, and applies repository-wide lint/style fixes across deployment, chain provider, analyzer, catalog, and engine packages.
Changes:
- Bumps Go/tooling and several Go dependencies, with a changeset for the release.
- Adds or adjusts lint suppressions, import grouping, naming fixes, and minor simplifications.
- Refactors small control-flow and helper patterns without broad feature changes.
Reviewed changes
Copilot reviewed 170 out of 171 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.changeset/slimy-icons-divide.md |
Adds minor release note for Go/dependency/lint updates. |
.github/workflows/pull-request-main.yml |
Updates golangci-lint version in PR CI. |
.github/workflows/schedule-main.yml |
Updates scheduled lint golangci-lint version. |
.tool-versions |
Bumps Go and golangci-lint tool versions. |
go.mod |
Bumps Go directive and dependencies. |
operations/validation.go |
Adjusts exhaustive lint suppression. |
offchain/ocr/secrets.go |
Adds revive suppression for exported type naming. |
offchain/node/config.go |
Adds revive suppression for exported type naming. |
offchain/jd/client.go |
Reorders imports and updates deprecation comments/lint suppression. |
offchain/jd/cognito_test.go |
Removes gosec suppression from test token literal. |
offchain/jd/memory/* |
Renames ID helper identifiers and adds revive suppression. |
jira/* |
Adds revive suppressions and simplifies zero-value test construction. |
experimental/analyzer/* |
Applies import grouping, lint suppressions, naming, and minor simplifications. |
engine/test/* |
Applies test lint simplifications and suppression comment updates. |
engine/cld/* |
Applies broad lint fixes, naming updates, small refactors, and suppression comments. |
deployment/* |
Applies doc/lint update and address-book branch simplification. |
datastore/catalog/* |
Applies lint-driven simplifications and test setup cleanup. |
cre/* |
Renames HTTP helpers and adds exported API lint suppressions. |
chain/* |
Applies provider naming/import/lint fixes and small control-flow simplifications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| module github.com/smartcontractkit/chainlink-deployments-framework | ||
|
|
||
| go 1.25.5 | ||
| go 1.26.2 |
| envGitHubToken = "GITHUB_TOKEN" //nolint:gosec // G101: not a credential, just env var name | ||
| envGHToken = "GH_TOKEN" |
| @@ -1,4 +1,4 @@ | |||
| package utils //nolint:revive // var-naming: We need to keep this name for now for backwards compatibility. | |||
| package utils | |||
| @@ -1,4 +1,4 @@ | |||
| package common //nolint:revive // var-naming: This is an internal package for common code that is shared between chains. | |||
| package common | |||
| if errors.Is(err, offchain.ErrEndpointsRequired) { | ||
| lggr.Warn("Skipping JD initialization: gRPC endpoint is not set in config") | ||
| } else { | ||
| return ForkedEnvironment{}, fmt.Errorf("failed to load offchain client: %w", err) | ||
| } | ||
|
|
||
| return ForkedEnvironment{}, fmt.Errorf("failed to load offchain client: %w", err) |
|
|
||
| // ScaffoldOptions holds configuration options for domain scaffolding. | ||
| type ScaffoldOptions struct { | ||
| type ScaffoldOptions struct { //nolint:revive // renaming would be a breaking change |
There was a problem hiding this comment.
I see many of these lint exclusiions for renaming, but I it is not actually clear what is wrong with these some of these names.
What is actually wrong with ScaffoldOptions?
There was a problem hiding this comment.
I ran the linter here and this passes if I remove the nolint directive
There was a problem hiding this comment.
In the new linter version, the linter complains the use of these "stutters". e.g. scaffold.ScaffoldOptions. As in go you always prefixs the package name in imports, the package name prefix is redundant. The idiomatic way to express this is scaffold.Options. It results obvious in use that Options refers to scaffold.
There was a problem hiding this comment.
This error is raised by smartcontractkit/.github/actions/ci-lint-go@ci-lint-go/v4.
| @@ -1,4 +1,4 @@ | |||
| package utils //nolint:revive // var-naming: We need to keep this name for now for backwards compatibility. | |||
| package utils | |||
| @@ -1,4 +1,4 @@ | |||
| package common //nolint:revive // var-naming: This is an internal package for common code that is shared between chains. | |||
| package common | |||
|
|
Closed in favor of #981 |
Followups:
KMSSigner.SignHash(txHash []byte)andisValidRecoveryThis changes are blocking NONEVM-4520