feat: ContractVersion in OperationMetadata (#979) by patricios-space · Pull Request #986 · smartcontractkit/chainlink-deployments-framework

patricios-space · 2026-05-18T14:10:27Z

feat: ContractVersion in OperationMetadata (#979)
feat: ContractFullyQualifiedName in TON's AdditionalFields
fix: revert ContractTypeAndVersion in OperationMetadata (#979)

feat: ContractFullyQualifiedName in TON's AdditionalFields fix: revert ContractTypeAndVersion in OperationMetadata (#979) This reverts commit 68a7a80.

changeset-bot · 2026-05-18T14:10:35Z

🦋 Changeset detected

Latest commit: c35fcdb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
chainlink-deployments-framework	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull request overview

This PR updates MCMS operation metadata handling to use ContractVersion instead of ContractTypeAndVersion, and adjusts TON analysis to decode via TON additional fields.

Changes:

Bumps github.com/smartcontractkit/mcms to a newer pseudo-version.
Replaces UPF metadata contractTypeAndVersion with contractVersion.
Updates TON analyzer/tests and fixtures for contractTypeFull-based decoding.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`go.mod`	Updates the MCMS dependency version.
`go.sum`	Updates MCMS checksums.
`experimental/analyzer/upf/upf.go`	Emits `ContractVersion` in UPF metadata.
`experimental/analyzer/upf/types.go`	Replaces UPF metadata type/version field with semver contract version.
`experimental/analyzer/upf/upf_test.go`	Updates TON UPF test transaction construction and expectations.
`experimental/analyzer/ton_analyzer.go`	Uses TON additional fields to resolve the decoder contract interface.
`experimental/analyzer/ton_analyzer_test.go`	Updates TON analyzer tests for `ContractVersion` and `contractTypeFull`.
`experimental/analyzer/decoded_call.go`	Resolves contract version from transaction metadata before datastore fallback.
`experimental/analyzer/report_builder_test.go`	Supplies TON additional fields in decode-failure tests.
`engine/test/internal/mcmsutils/testdata/timelock_proposal.json`	Removes deprecated contract type/version fixture field.
`engine/test/internal/mcmsutils/testdata/proposal.json`	Removes deprecated contract type/version fixture field.
`engine/cld/commands/mcms/testdata/proposal.json`	Removes deprecated contract type/version fixture fields.
`.changeset/bold-olives-smell.md`	Adds a minor changeset for the metadata change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

gustavogama-cll · 2026-05-18T20:57:28Z

-	if tv.Version.Original() != "" {
-		cv = tv.Version.String()
+	// If version wasn't already set from transaction metadata, use datastore version
+	if contractVersion == "" && tv.Version.Original() != "" {


I think it should be the opposite: the datastore value should have precedence over the proposal metadata.

@ecPablo @ChrisAmora , what are your thoughts?

Yes, it's more likely that datastore has more up-to-date data. For example, I generate proposalA that uses contractVersion 1.0.0, then very shortly after, someone updates datastore to contractVersion 2.0.0. I'd expect the decoded version to show me the 2.0.0 as that's the current on chain state. The only reasons where this could not be true is if we have out-of-cld systems updating the contracts, in that case maybe the proposal might be safer source of truth. But I don't think that's the case here.

Ok, let's keep system context (DS) to have priority. Override can be made with updating the DS directly with the proposal PR (if something is off).

Finally, we should also be able to interact with ad-hoc contracts which are not stored, and for that cases the proposal input ref (type, version) should resolve properly.

gustavogama-cll

Let's just settle how to handle this (because it affects other chains too) and then we can merge. Though I'd appreciate if you could enhance the UPF test as requested.

krebernisak · 2026-05-19T08:07:41Z

+		bindings.ShortRBAC,
+		semver.MustParse("1.2.3"),
+		bindings.TypeRBAC,


nit: for TON we don't need to input both the bindings.ShortRBAC (short) and bindings.TypeRBAC (full) as the former can be derived from the latter

Not if the full type is a trait type. Short type is only used for the contract type as stored in the DS.

krebernisak · 2026-05-19T08:11:36Z

+			return ""
+		}
+
+		fullyQualifiedName := string(additionalFields.ContractTypeFull)


nit: Let's extract into a type/func which we document and allows anybody to produce a FQN

krebernisak · 2026-05-19T08:15:23Z

-		ContractType:    string(bindings.TypeRBAC),
-		ContractVersion: "0.0.0",
+		Address:      s.targetAddr.String(),
+		Method:       string(bindings.TypeRBAC) + "::GrantRole(0x95cd540f)",


nit: this DecodedCall should also contain a contract version, maybe as part of the Method by using a FQN vs ContractTypeFull (missing version)

This was already done but it was not covered by test. Added a case to confirm this

krebernisak · 2026-05-19T08:25:57Z

-	if tv.Version.Original() != "" {
-		cv = tv.Version.String()
+	// If version wasn't already set from transaction metadata, use datastore version
+	if contractVersion == "" && tv.Version.Original() != "" {


Ok, let's keep system context (DS) to have priority. Override can be made with updating the DS directly with the proposal PR (if something is off).

Finally, we should also be able to interact with ad-hoc contracts which are not stored, and for that cases the proposal input ref (type, version) should resolve properly.

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.

 	dsAddContract(t, ds, 16423721717087811551, "RmnXLft1mSEwDgMKu2okYuHkiazxntFFcZFrrcXxYg7", "RMNRemote 1.0.0")

+	// ---- TON: testnet
+	dsAddContract(t, ds, chainsel.TON_TESTNET.Selector, "EQADa3W6G0nSiTV4a6euRA42fU9QxSEnb-WeDpcrtWzA2jM8", "MCMS 1.0.0")


-		errStr := fmt.Errorf("failed to decode TON transaction: %w", err)
+		errStr := "failed to decode TON transaction: " + err.Error()
+		if typeErr != "" {
+			errStr += "; additionally" + typeErr


+			wantErrContain: "unknown contract interface: link.chain.ton.lib.access.RBAC@0.0.0",
+		},
+		{
+			name: "success - RBAC GrantRol with version",


Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.


+	// ---- TON: testnet
+	dsAddContract(t, ds, chainsel.TON_TESTNET.Selector, "EQADa3W6G0nSiTV4a6euRA42fU9QxSEnb-WeDpcrtWzA2jM8", "MCMS 1.0.0")
+	dsAddContract(t, ds, chainsel.TON_TESTNET.Selector, "EQADa3W6G0nSiTV4a6euRA42fU9QxSEnb-WeDpcrtWzA2jM8", "Router 1.2.3")


cl-sonarqube-production · 2026-05-19T14:12:01Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
96.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

patricios-space · 2026-05-19T14:32:16Z

+		fullyQualifiedName := string(additionalFields.ContractTypeFull)
+		// If ContractVersion is provided, append it to the fully qualified name to ensure the decoder uses the correct version.
+		// If it is skipped, the decoder will use the latest version available for the contract type.
+		// Note: we don't use contractVersion from resolveContractInfo because that only represents the short type used by the datastore.
+		if mcmsTx.ContractVersion != nil {
+			fullyQualifiedName += "@" + mcmsTx.ContractVersion.String()
+		}


We don't want this in TON because we only want to select a version explicitly via TX params

feat: ContractVersion in OperationMetadata (#979)

2aabdbf

feat: ContractFullyQualifiedName in TON's AdditionalFields fix: revert ContractTypeAndVersion in OperationMetadata (#979) This reverts commit 68a7a80.

patricios-space added 3 commits May 18, 2026 13:36

fix: add version to fully qualified name

5311b31

feat: changeset

f7f09ea

fix: contractVersion ommit empty

42f1045

patricios-space marked this pull request as ready for review May 18, 2026 17:33

Copilot AI review requested due to automatic review settings May 18, 2026 17:33

patricios-space requested a review from a team as a code owner May 18, 2026 17:33

patricios-space requested a review from krebernisak May 18, 2026 17:33

Copilot started reviewing on behalf of patricios-space May 18, 2026 17:33 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread experimental/analyzer/ton_analyzer.go Outdated

Comment thread experimental/analyzer/ton_analyzer.go Outdated

Comment thread experimental/analyzer/upf/upf.go

patricios-space added 2 commits May 18, 2026 14:46

fix: bump imports

c314860

fix: empty cell

651039c

Copilot AI review requested due to automatic review settings May 18, 2026 18:03

Copilot started reviewing on behalf of patricios-space May 18, 2026 18:03 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

patricios-space added 2 commits May 18, 2026 16:27

fix: apply suggestions

88be8e4

fix: bump imports

237b655

Copilot AI review requested due to automatic review settings May 18, 2026 19:57

Copilot started reviewing on behalf of patricios-space May 18, 2026 19:58 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread experimental/analyzer/ton_analyzer.go

Comment thread experimental/analyzer/ton_analyzer.go Outdated

Comment thread experimental/analyzer/upf/upf.go

test: contractVersion in proposal

4d69cd7

patricios-space requested a review from gustavogama-cll May 18, 2026 20:28

gustavogama-cll reviewed May 18, 2026

View reviewed changes

Comment thread experimental/analyzer/upf/upf_test.go Outdated

gustavogama-cll reviewed May 18, 2026

View reviewed changes

krebernisak previously approved these changes May 19, 2026

View reviewed changes

patricios-space added 2 commits May 19, 2026 09:04

fix: give ds version higher priority

d558e85

test: contract version in method prefix

aad11d8

Copilot AI review requested due to automatic review settings May 19, 2026 12:05

Copilot started reviewing on behalf of patricios-space May 19, 2026 12:05 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

Comment thread experimental/analyzer/ton_analyzer.go Outdated

Comment thread experimental/analyzer/ton_analyzer_test.go Outdated

Comment thread experimental/analyzer/ton_analyzer.go

Comment thread experimental/analyzer/ton_analyzer.go

patricios-space added 2 commits May 19, 2026 10:41

ref: merge ton test into generic test

9620685

fix: use mcmsTx.ContractVersion

99a5e84

Copilot AI review requested due to automatic review settings May 19, 2026 13:48

Copilot AI reviewed May 19, 2026

View reviewed changes

patricios-space added 2 commits May 19, 2026 10:57

fix: error concatenation

8bc04c0

fix: lint

5fa5480

Copilot AI review requested due to automatic review settings May 19, 2026 13:59

Copilot started reviewing on behalf of patricios-space May 19, 2026 13:59 View session

patricios-space removed the request for review from Copilot May 19, 2026 14:01

Copilot started reviewing on behalf of patricios-space May 19, 2026 14:03 View session

fix: nolint

dd9760c

Copilot AI review requested due to automatic review settings May 19, 2026 14:04

Copilot AI reviewed May 19, 2026

View reviewed changes

fix: duplicated entry

c35fcdb

Copilot AI review requested due to automatic review settings May 19, 2026 14:15

Copilot AI reviewed May 19, 2026

View reviewed changes

Copilot started reviewing on behalf of patricios-space May 19, 2026 14:22 View session

patricios-space requested review from ecPablo, gustavogama-cll and krebernisak May 19, 2026 14:40

Copilot started reviewing on behalf of patricios-space May 19, 2026 14:42 View session

gustavogama-cll approved these changes May 19, 2026

View reviewed changes

patricios-space added this pull request to the merge queue May 19, 2026

Merged via the queue into main with commit af2cb57 May 19, 2026
28 of 29 checks passed

patricios-space deleted the ref/ton/replace-ContractTypeAndVersion-with-additionalFields branch May 19, 2026 16:38

app-token-issuer-engops Bot mentioned this pull request May 19, 2026

Version Packages #989

Merged

Uh oh!

Conversation

patricios-space commented May 18, 2026

Uh oh!

changeset-bot Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gustavogama-cll left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

cl-sonarqube-production Bot commented May 19, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

changeset-bot Bot commented May 18, 2026 •

edited

Loading

gustavogama-cll left a comment •

edited

Loading