fix lint, fix method name for go-ethereum JSON RPC mapping

Author: vreff

pkg/client/chain_client_test.go

@@ -504,7 +504,7 @@ type sendTxService struct {
 	sentCount atomic.Int32
 }
 
-func (x *sendTxService) ChainID(ctx context.Context) (*hexutil.Big, error) {
+func (x *sendTxService) ChainId(ctx context.Context) (*hexutil.Big, error) {
 	return (*hexutil.Big)(x.chainID), nil
 }
 

pkg/txmgr/evm_tx_store_test.go

@@ -650,7 +650,7 @@ func Test_FindTxWithIdempotencyKey(t *testing.T) {
 
 	t.Run("returns nil error if no results", func(t *testing.T) {
 		idempotencyKey := "777"
-		etx, err := txStore.FindTxWithIdempotencyKey(tests.Context(t), idempotencyKey, testutils.FixtureChainID)
+		etx, err := txStore.FindTxWithIdempotencyKey(t.Context(), idempotencyKey, testutils.FixtureChainID)
 		require.NoError(t, err)
 		assert.Nil(t, etx)
 	})
@@ -662,7 +662,7 @@ func Test_FindTxWithIdempotencyKey(t *testing.T) {
 			txRequestWithIdempotencyKey(idempotencyKey))
 		require.Equal(t, idempotencyKey, *etx.IdempotencyKey)
 
-		res, err := txStore.FindTxWithIdempotencyKey(tests.Context(t), idempotencyKey, testutils.FixtureChainID)
+		res, err := txStore.FindTxWithIdempotencyKey(t.Context(), idempotencyKey, testutils.FixtureChainID)
 		require.NoError(t, err)
 		assert.Equal(t, etx.Sequence, res.Sequence)
 		require.Equal(t, idempotencyKey, *res.IdempotencyKey)
@@ -679,7 +679,7 @@ func Test_FindReceiptWithIdempotencyKey(t *testing.T) {
 
 	idempotencyKey := "654"
 	t.Run("returns nil error if no results", func(t *testing.T) {
-		r, err := txStore.FindReceiptWithIdempotencyKey(tests.Context(t), idempotencyKey, testutils.FixtureChainID)
+		r, err := txStore.FindReceiptWithIdempotencyKey(t.Context(), idempotencyKey, testutils.FixtureChainID)
 		require.NoError(t, err)
 		assert.Nil(t, r)
 	})

pkg/txmgr/txmgr_test.go

@@ -107,7 +107,7 @@ func TestTxm_SendNativeToken_DoesNotSendToZero(t *testing.T) {
 	txm, err := makeTestEvmTxm(t, db, ethClient, estimator, evmConfig, evmConfig.GasEstimator(), evmConfig.Transactions(), dbConfig, dbConfig.Listener(), &keystest.FakeChainStore{})
 	require.NoError(t, err)
 
-	_, err = txm.SendNativeToken(tests.Context(t), testutils.FixtureChainID, from, to, *value, 21000)
+	_, err = txm.SendNativeToken(t.Context(), testutils.FixtureChainID, from, to, *value, 21000)
 	require.Error(t, err)
 	require.EqualError(t, err, "cannot send native token to zero address")
 }