Skip to content

Commit 91a892a

Browse files
authored
Fix TransactionReceipt rpc call args (#457)
* Fix TransactionReceipt rpc call args * lint
1 parent ce3a2c8 commit 91a892a

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

pkg/client/rpc_client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,7 @@ func (r *RPCClient) SubscribeToHeads(ctx context.Context) (ch <-chan *evmtypes.H
531531
// GethClient wrappers
532532

533533
func (r *RPCClient) TransactionReceipt(ctx context.Context, txHash common.Hash) (receipt *evmtypes.Receipt, err error) {
534-
err = r.CallContext(ctx, &receipt, "eth_getTransactionReceipt", txHash, false)
534+
err = r.CallContext(ctx, &receipt, "eth_getTransactionReceipt", txHash)
535535
if err != nil {
536536
return nil, err
537537
}
@@ -544,7 +544,7 @@ func (r *RPCClient) TransactionReceipt(ctx context.Context, txHash common.Hash)
544544

545545
func (r *RPCClient) TransactionReceiptWithOpts(ctx context.Context, txHash common.Hash, opts evmtypes.TransactionReceiptOpts) (receipt *evmtypes.Receipt, err error) {
546546
ctx = r.wrapCtx(ctx, opts.IsExternalRequest)
547-
err = r.CallContext(ctx, &receipt, "eth_getTransactionReceipt", txHash, false)
547+
err = r.CallContext(ctx, &receipt, "eth_getTransactionReceipt", txHash)
548548
if err != nil {
549549
return nil, err
550550
}

pkg/client/rpc_client_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1300,6 +1300,9 @@ func TestRPCClient_TransactionReceiptWithOpts(t *testing.T) {
13001300
httpURL := testutils.NewHTTPServer(t, testutils.FixtureChainID, func(method string, params gjson.Result) (resp testutils.JSONRPCResponse) {
13011301
switch method {
13021302
case "eth_getTransactionReceipt":
1303+
require.True(t, params.IsArray())
1304+
require.Len(t, params.Array(), 1)
1305+
require.Equal(t, common.Hash{}.Hex(), params.Array()[0].String())
13031306
resp.Result = receiptJSON
13041307
default:
13051308
require.Fail(t, "unexpected method: "+method)
@@ -1318,6 +1321,9 @@ func TestRPCClient_TransactionReceiptWithOpts(t *testing.T) {
13181321
httpURL := testutils.NewHTTPServer(t, testutils.FixtureChainID, func(method string, params gjson.Result) (resp testutils.JSONRPCResponse) {
13191322
switch method {
13201323
case "eth_getTransactionReceipt":
1324+
require.True(t, params.IsArray())
1325+
require.Len(t, params.Array(), 1)
1326+
require.Equal(t, common.Hash{}.Hex(), params.Array()[0].String())
13211327
resp.Result = receiptJSON
13221328
default:
13231329
require.Fail(t, "unexpected method: "+method)

0 commit comments

Comments
 (0)