Merge commit 'f190212bab15e84fe49db88f495ad026e6c1d520' into oev-393_metaclient

Author: dimriou

.github/CODEOWNERS

@@ -77,3 +77,4 @@ go.mod @smartcontractkit/core @smartcontractkit/foundations @smartcontractkit/co
 go.sum @smartcontractkit/core @smartcontractkit/foundations @smartcontractkit/core-solidity
 
 pkg/txm @dimriou @smartcontractkit/bix-framework @smartcontractkit/core
+pkg/bindings @smartcontractkit/bix-framework

.github/workflows/build-test.yml

@@ -3,63 +3,104 @@ name: Build and Test
 on: [pull_request]
 
 jobs:
-  build-test:
+  build-test-matrix:
     runs-on: ubuntu-latest
-    defaults:
-      run:
-        working-directory: pkg # applied only for "run" steps
+
     env:
       # We explicitly have this env var not be "CL_DATABASE_URL" to avoid having it be used by core related tests
       # when they should not be using it, while still allowing us to DRY up the setup
       DB_URL: postgresql://postgres:postgres@localhost:5432/chainlink_test?sslmode=disable
+
+    strategy:
+      fail-fast: false
+      matrix:
+        type:
+          # TODO only run when needed
+          - path: .
+            should-run: "true"
+            requires-foundry: "false"
+          - path: ./gethwrappers
+            should-run: "true"
+            requires-foundry: "true"
+
     steps:
       - name: Checkout
         uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
 
       - name: Set up Go
+        if: ${{ matrix.type.should-run == 'true' }}
         uses: actions/setup-go@v5
         with:
-          cache-dependency-path: go.sum
-          go-version-file: go.mod
+          cache-dependency-path: ${{ matrix.type.path }}/go.sum
+          go-version-file: ${{ matrix.type.path }}/go.mod
+
+      # Only needed because we use the NPM versions of packages and not native Foundry.
+      - name: Setup NodeJS
+        if: ${{ matrix.type.should-run == 'true' && matrix.type.requires-foundry == 'true' }}
+        uses: ./.github/actions/setup-nodejs
+        with:
+          prod: "true"
+
+      - name: Install Foundry
+        if: ${{ matrix.type.should-run == 'true' && matrix.type.requires-foundry == 'true' }}
+        uses: ./.github/actions/install-solidity-foundry
 
       - name: Build
+        if: ${{ matrix.type.should-run == 'true' }}
         run: go build ./...
+        working-directory: ${{ matrix.type.path }}
 
       - name: Setup Postgres
+        if: ${{ matrix.type.should-run == 'true' }}
         uses: smartcontractkit/.github/actions/setup-postgres@7aa7ce23687ba493e9ba9c6ad47a063e60ae3433 # setup-postgres@0.1.0
 
       - name: Setup DB
+        if: ${{ matrix.type.should-run == 'true' }}
         run: make testdb
+        working-directory: ./pkg
         env:
           CL_DATABASE_URL: ${{ env.DB_URL }}
 
       - name: Unit Tests
+        if: ${{ matrix.type.should-run == 'true' }}
         run: GORACE="log_path=$PWD/race" go test -race ./... -coverpkg=./... -coverprofile=coverage.txt
+        working-directory: ${{ matrix.type.path }}
         env:
           CL_DATABASE_URL: ${{ env.DB_URL }}
 
       - name: Print Races
-        if: failure()
+        if: ${{ matrix.type.should-run == 'true' && failure() }}
         run: |
           find race.* | xargs cat > race.txt
           if [[ -s race.txt ]]; then
             cat race.txt
           fi
+        working-directory: ${{ matrix.type.path }}
 
       - name: Upload Go test results
-        if: always()
+        if: ${{ matrix.type.should-run == 'true' }}
         uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
         with:
           name: go-test-results
           path: |
-            pkg/coverage.txt
-            pkg/race.*
+            ${{ matrix.type.path }}/pkg/coverage.txt
+            ${{ matrix.type.path }}/pkg/race.*
+
+
+  build-test:
+    if: always()
+    needs: [ build-test-matrix ]
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check format statuses and fail if any of them failed or were cancelled
+        if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}
+        run: |
+          echo "At least one format check failed or was cancelled. Please check the logs."
+          exit 1
+      - run: echo 'Success'
 
   check-tidy:
     runs-on: ubuntu-latest
-    defaults:
-      run:
-        working-directory: pkg # applied only for "run" steps
     steps:
       - name: Checkout
         uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
@@ -72,12 +113,12 @@ jobs:
 
       - name: Ensure gomodtidy has been run
         run: |
-          go mod tidy
+          make tidy
           git add --all
           git diff --minimal --cached --exit-code
 
       - name: Ensure "make generate" has been run
         run: |
           make rm-mocked && make generate
           git add --all
-          git diff --stat --cached --exit-code
+          git diff --stat --cached --exit-code

.github/workflows/ci-protobuf.yml

@@ -203,6 +203,7 @@ jobs:
         uses: baptiste0928/cargo-install@904927dbe77864e0f2281519fe9d5bd097a220b3 # v3.1.1
         with:
           crate: svm-rs
+          version: '0.5.17'
 
       - name: Find and install all Solc versions with SVM
         if: ${{ steps.check-for-solc-version.outputs.has_solc_version == 'false'

.github/workflows/solidity-foundry.yml

@@ -11,6 +11,7 @@ linters:
     - exhaustive
     - fatcontext
     - ginkgolinter
+    - gomoddirectives
     - gocritic
     - goimports
     - gosec
@@ -179,3 +180,4 @@ issues:
         - gosec
   exclude-files:
     - evm/ # need to move files here for evm extraction that have outstanding issues
+    - pkg/bindings/abigen

.golangci.yml

@@ -270,6 +270,7 @@ Set to zero to disable.
 ## Transactions
 ```toml
 [Transactions]
+ConfirmationTimeout = '60s' # Default
 Enabled = true # Default
 ForwardersEnabled = false # Default
 MaxInFlight = 16 # Default
@@ -280,6 +281,12 @@ ResendAfterThreshold = '1m' # Default
 ```
 
 
+### ConfirmationTimeout
+```toml
+ConfirmationTimeout = '60s' # Default
+```
+ConfirmationTimeout time to wait for a TX to get into a block in the blockchain. This is used for the EVMService.SubmitTransaction operation.
+
 ### Enabled
 ```toml
 Enabled = true # Default
@@ -796,9 +803,10 @@ the prices and end up in stale values.
 HistoryDepth = 100 # Default
 MaxBufferSize = 3 # Default
 SamplingInterval = '1s' # Default
-FinalityTagBypass = true # Default
+FinalityTagBypass = false # Default
 MaxAllowedFinalityDepth = 10000 # Default
 PersistenceEnabled = true # Default
+PersistenceBatchSize = 100 # Default
 ```
 The head tracker continually listens for new heads from the chain.
 
@@ -831,11 +839,10 @@ SamplingInterval means that head tracker callbacks will at maximum be made once
 
 ### FinalityTagBypass
 ```toml
-FinalityTagBypass = true # Default
+FinalityTagBypass = false # Default
 ```
 FinalityTagBypass disables FinalityTag support in HeadTracker and makes it track blocks up to FinalityDepth from the most recent head.
-It should only be used on chains with an extremely large actual finality depth (the number of blocks between the most recent head and the latest finalized block).
-Has no effect if `FinalityTagsEnabled` = false
+This param is considered deprecated, and should be set to false on all chains
 
 ### MaxAllowedFinalityDepth
 ```toml
@@ -854,6 +861,16 @@ Persistence is helpful on chains with large finality depth, where fetching block
 On chains with fast finality, the persistence layer does not improve the chain's load time and only consumes database resources (mainly IO).
 NOTE: persistence should not be disabled for products that use LogBroadcaster, as it might lead to missed on-chain events.
 
+### PersistenceBatchSize
+```toml
+PersistenceBatchSize = 100 # Default
+```
+PersistenceBatchSize is used to batch head tracker db transactions (inserts and deletes).
+If set to 100, the head tracker will insert and delete to the db every 100 heads.
+If the head tracker crashes before the batch size is reached (i.e it fails to write the current batch to the db).
+Then it will have to load that batch of heads from the rpc on startup (check PersistenceEnabled above).
+To limit that initial fetch while also improving db usage, 100 is the default for now.
+
 ## KeySpecific
 ```toml
 [[KeySpecific]]
@@ -888,6 +905,7 @@ EnforceRepeatableRead = true # Default
 DeathDeclarationDelay = '1m' # Default
 NewHeadsPollInterval = '0s' # Default
 VerifyChainID = true # Default
+ExternalRequestMaxResponseSize = 0 # Default
 ```
 The node pool manages multiple RPC endpoints.
 
@@ -995,6 +1013,17 @@ VerifyChainID = true # Default
 ```
 VerifyChainID enforces RPC Client ChainIDs to match configured ChainID
 
+### ExternalRequestMaxResponseSize
+```toml
+ExternalRequestMaxResponseSize = 0 # Default
+```
+ExternalRequestMaxResponseSize sets the maximum allowed size (in bytes) for responses to external requests.
+Responses larger than this value will be rejected to prevent the node from being overloaded.
+Only CRE workflow requests are considered external requests.
+Only applies for RPCs configured with HTTP urls. There is no limit for WS only RPCs, as WS RPCs only allow to define
+global limits that are applied to both internal and external requests.
+Set to 0 to disable the size check and allow responses of any size.
+
 ## NodePool.Errors
 :warning: **_ADVANCED_**: _Do not change these settings unless you know what you are doing._
 ```toml
@@ -1175,6 +1204,7 @@ HTTPURL = 'https://foo.web' # Example
 HTTPURLExtraWrite = 'https://foo.web/extra' # Example
 SendOnly = false # Default
 Order = 100 # Default
+IsLoadBalancedRPC = false # Example
 ```
 
 
@@ -1214,6 +1244,14 @@ Order = 100 # Default
 ```
 Order of the node in the pool, will takes effect if `SelectionMode` is `PriorityLevel` or will be used as a tie-breaker for `HighestHead` and `TotalDifficulty`
 
+### IsLoadBalancedRPC
+```toml
+IsLoadBalancedRPC = false # Example
+```
+IsLoadBalancedRPC indicates whether the http/ws url above has multiple rpc's behind it.
+If true, we should try reconnecting to the node even when its the only node in the Nodes list.
+If false and its the only node in the nodes list, we will mark it alive even when its out of sync, because it might still be able to send txs.
+
 ## OCR2.Automation
 ```toml
 [OCR2.Automation]
@@ -1233,6 +1271,9 @@ GasLimit controls the gas limit for transmit transactions from ocr2automation jo
 FromAddress = '0x2a3e23c6f242F5345320814aC8a1b4E58707D292' # Example
 ForwarderAddress = '0x2a3e23c6f242F5345320814aC8a1b4E58707D292' # Example
 GasLimitDefault = 400_000 # Default
+TxAcceptanceState = 2 # Default
+PollPeriod = '2s' # Default
+AcceptanceTimeout = '30s' # Default
 ```
 
 
@@ -1254,3 +1295,21 @@ GasLimitDefault = 400_000 # Default
 ```
 GasLimitDefault is the default gas limit for workflow transactions.
 
+### TxAcceptanceState
+```toml
+TxAcceptanceState = 2 # Default
+```
+TxAcceptanceState is the default acceptance state for writer DON tranmissions.
+
+### PollPeriod
+```toml
+PollPeriod = '2s' # Default
+```
+PollPeriod is the default poll period for checking transmission state
+
+### AcceptanceTimeout
+```toml
+AcceptanceTimeout = '30s' # Default
+```
+AcceptanceTimeout is the default timeout for a tranmission to be accepted on chain
+