Return error when Forwarders are not enabled

[dimriou]

This PR makes TXMv2 Orchestrator's methods more aligned with v1's txmgr to enable DFs without forwarders

[github-actions]

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-evm

⚠️ Breaking Changes (10)

pkg/config.TransactionManagerV2 (2)

• CustomURL — ➕ Added

• CustomURLs — 🗑️ Removed

pkg/config/toml.TransactionManagerV2Config (1)

• CustomURLs — 🗑️ Removed

pkg/txm/clientwrappers/dualbroadcast (1)

• SelectClient — Type changed:

func(
  github.com/smartcontractkit/chainlink-common/pkg/logger.Logger, 
  github.com/smartcontractkit/chainlink-evm/pkg/client.Client, 
  github.com/smartcontractkit/chainlink-evm/pkg/keys.ChainStore, 
  - []*net/url.URL, 
  + *net/url.URL, 
  *math/big.Int, 
  github.com/smartcontractkit/chainlink-evm/pkg/txm.TxStore, 
  bool, 
  *bool, 
  *time.Duration, 
  github.com/smartcontractkit/chainlink-evm/pkg/txm.Metrics
)
(github.com/smartcontractkit/chainlink-evm/pkg/txm.Client, github.com/smartcontractkit/chainlink-evm/pkg/txm.ErrorHandler, error)

pkg/txmgr.(*evmTxmMetrics) (1)

• IncrementNumFinalizedTxs — 🗑️ Removed

pkg/txmgr.EvmTxStore (1)

• OldestNonTerminalTxAgeSeconds — ➕ Added

pkg/txmgr.finalizerMetrics (3)

• AddNumFinalizedTxs — ➕ Added

• IncrementNumFinalizedTxs — 🗑️ Removed

• RecordOldestNonTerminalTxAgeSeconds — ➕ Added

pkg/txmgr.finalizerTxStore (1)

• OldestNonTerminalTxAgeSeconds — ➕ Added

✅ Compatible Changes (12)

pkg/client (1)

• IsBatchRPCResponseEnvelopeUnmarshalError — ➕ Added

pkg/txm/clientwrappers/dualbroadcast (5)

• FlashbotsClient — ➕ Added

• FlashbotsClientRPC — ➕ Added

• NewFlashbotsClient — ➕ Added

• Privacy — ➕ Added

• RefundConfig — ➕ Added

pkg/txmgr.(*evmTxStore) (1)

• OldestNonTerminalTxAgeSeconds — ➕ Added

pkg/txmgr.(*evmTxmMetrics) (2)

• AddNumFinalizedTxs — ➕ Added

• RecordOldestNonTerminalTxAgeSeconds — ➕ Added

pkg/txmgr/mocks (1)

• EvmTxStore_OldestNonTerminalTxAgeSeconds_Call — ➕ Added

pkg/txmgr/mocks.(*EvmTxStore) (1)

• OldestNonTerminalTxAgeSeconds — ➕ Added

pkg/txmgr/mocks.(*EvmTxStore_Expecter) (1)

• OldestNonTerminalTxAgeSeconds — ➕ Added

---

📄 View full apidiff report

[Copilot]

Pull request overview

This PR updates the TXMv2 Orchestrator to better align its behavior with the legacy txmgr, particularly around forwarder handling when forwarders are disabled.

Changes:

• Fixes CreateTransaction to return the actual keystore “not enabled” error (kErr) in NotEnabledError.
• Changes GetForwarderForEOA* methods to return an explicit error when forwarding is disabled (o.fwdMgr == nil).
• Replaces the prior CountTransactionsByState implementation with an unimplemented error.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.