fix linter issues

poopoothegorilla · poopoothegorilla · commit 5add104f4095 · 2026-02-18T15:09:46.000-05:00
diff --git a/multinode/node_selector_random_rpc.go b/multinode/node_selector_random_rpc.go
@@ -32,6 +32,7 @@ func (s *randomRPCSelector[CHAIN_ID, RPC]) Select() Node[CHAIN_ID, RPC] {
 		return nil
 	}
 
+	// #nosec G404
 	return liveNodes[rand.IntN(len(liveNodes))]
 }
 
diff --git a/multinode/node_selector_random_rpc_test.go b/multinode/node_selector_random_rpc_test.go
@@ -82,7 +82,7 @@ func TestRandomRPCNodeSelector_Distribution(t *testing.T) {
 
 	// Each node should be selected at least once with overwhelming probability
 	for _, n := range nodes {
-		assert.Greater(t, counts[n], 0, "expected every alive node to be selected at least once")
+		assert.Positive(t, counts[n], "expected every alive node to be selected at least once")
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ func (s *randomRPCSelector[CHAIN_ID, RPC]) Select() Node[CHAIN_ID, RPC] {`
`32`	`32`	`return nil`
`33`	`33`	`}`
`34`	`34`
	`35`	`+ // #nosec G404`
`35`	`36`	`return liveNodes[rand.IntN(len(liveNodes))]`
`36`	`37`	`}`
`37`	`38`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ func TestRandomRPCNodeSelector_Distribution(t *testing.T) {`
`82`	`82`
`83`	`83`	`// Each node should be selected at least once with overwhelming probability`
`84`	`84`	`for _, n := range nodes {`
`85`		`- assert.Greater(t, counts[n], 0, "expected every alive node to be selected at least once")`
	`85`	`+ assert.Positive(t, counts[n], "expected every alive node to be selected at least once")`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`