lint

Author: DylanTinianov

metrics/multinode_test.go

@@ -41,7 +41,11 @@ func TestMultiNodeMetrics_RecordNodeClientVersion(t *testing.T) {
 		"rpc-1.2.3",
 	))
 
-	require.Equal(t, float64(1), value)
+	require.InEpsilon(t,
+		1.0,
+		value,
+		0.001,
+	)
 }
 
 func TestMultiNodeMetrics_Verifies(t *testing.T) {

multinode/node_lifecycle.go

@@ -110,15 +110,15 @@ func (n *node[CHAIN_ID, HEAD, RPC]) aliveLoop() {
 			n.metrics.IncrementPolls(ctx, n.name)
 			lggr.Tracew("Pinging RPC", "nodeState", n.State(), "pollFailures", pollFailures)
 			pollCtx, cancel := context.WithTimeout(ctx, pollInterval)
-			version, err := n.RPC().PingClientVersion(pollCtx)
+			version, pingErr := n.RPC().PingClientVersion(pollCtx)
 			cancel()
-			if err != nil {
+			if pingErr != nil {
 				// prevent overflow
 				if pollFailures < math.MaxUint32 {
 					n.metrics.IncrementPollsFailed(ctx, n.name)
 					pollFailures++
 				}
-				lggr.Warnw(fmt.Sprintf("Poll failure, RPC endpoint %s failed to respond properly", n.String()), "err", err, "pollFailures", pollFailures, "nodeState", n.getCachedState())
+				lggr.Warnw(fmt.Sprintf("Poll failure, RPC endpoint %s failed to respond properly", n.String()), "err", pingErr, "pollFailures", pollFailures, "nodeState", n.getCachedState())
 			} else {
 				lggr.Debugw("Ping successful", "nodeState", n.State())
 				n.metrics.RecordNodeClientVersion(ctx, n.name, version)

multinode/node_test.go

@@ -1,16 +1,16 @@
 package multinode
 
 import (
-	"github.com/smartcontractkit/chainlink-framework/metrics"
-	"github.com/stretchr/testify/require"
 	"net/url"
 	"testing"
 	"time"
 
 	"github.com/stretchr/testify/mock"
+	"github.com/stretchr/testify/require"
 
 	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 
+	"github.com/smartcontractkit/chainlink-framework/metrics"
 	"github.com/smartcontractkit/chainlink-framework/multinode/mocks"
 )