Skip to content

Commit a463c3e

Browse files
jmank88jmank88
committed
multinode: reduce stack traces
1 parent e82bc07 commit a463c3e

7 files changed

Lines changed: 289 additions & 265 deletions

File tree

‎.github/workflows/golangci_lint.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ jobs:
3636
go-version-file: ${{ matrix.module }}/go.mod
3737

3838
- name: Run golangci-lint for ${{ matrix.module }}
39-
uses: golangci/golangci-lint-action@4696ba8babb6127d732c3c6dde519db15edab9ea # v6.5.1
39+
uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
4040
with:
4141
args: --config=${{ github.workspace }}/.golangci.yml
4242
only-new-issues: true
43-
version: v1.64.2
43+
version: v2.10.1
4444
working-directory: ${{ matrix.module }}
4545

4646
# Per https://github.com/orgs/community/discussions/4324, we need to capture a matrix-job result

‎.golangci.yml‎

Lines changed: 104 additions & 96 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
run:
2-
timeout: 15m0s
1+
version: "2"
32
linters:
43
enable:
54
- containedctx
@@ -10,7 +9,6 @@ linters:
109
- fatcontext
1110
- ginkgolinter
1211
- gocritic
13-
- goimports
1412
- gosec
1513
- loggercheck
1614
- mirror
@@ -25,96 +23,106 @@ linters:
2523
- testifylint
2624
- unconvert
2725
- whitespace
28-
linters-settings:
29-
exhaustive:
30-
default-signifies-exhaustive: true
31-
goimports:
32-
local-prefixes: github.com/smartcontractkit/chainlink
33-
gosec:
34-
excludes:
35-
- G101
36-
- G104
37-
# - G204
38-
# - G304
39-
# - G404
40-
govet:
41-
enable:
42-
- shadow
43-
revive:
44-
confidence: 0.8
45-
rules:
46-
- name: blank-imports
47-
- name: context-as-argument
48-
- name: context-keys-type
49-
- name: dot-imports
50-
- name: error-return
51-
- name: error-strings
52-
- name: error-naming
53-
- name: exported
54-
- name: if-return
55-
- name: increment-decrement
56-
- name: var-naming
57-
- name: var-declaration
58-
- name: package-comments
59-
- name: range
60-
- name: receiver-naming
61-
- name: time-naming
62-
# - name: unexported-return
63-
- name: indent-error-flow
64-
- name: errorf
65-
- name: empty-block
66-
- name: superfluous-else
67-
# - name: unused-parameter
68-
- name: unreachable-code
69-
- name: redefines-builtin-id
70-
- name: waitgroup-by-value
71-
- name: unconditional-recursion
72-
- name: struct-tag
73-
# - name: string-format
74-
- name: string-of-int
75-
- name: range-val-address
76-
- name: range-val-in-closure
77-
- name: modifies-value-receiver
78-
- name: modifies-parameter
79-
- name: identical-branches
80-
- name: get-return
81-
# - name: flag-parameter
82-
- name: early-return
83-
- name: defer
84-
- name: constant-logical-expr
85-
# - name: confusing-naming
86-
# - name: confusing-results
87-
- name: bool-literal-in-expr
88-
- name: atomic
89-
depguard:
90-
rules:
91-
main:
92-
list-mode: lax
93-
deny:
94-
- pkg: cosmossdk.io/errors
95-
desc: Use the standard library instead
96-
- pkg: github.com/gofrs/uuid
97-
desc: Use github.com/google/uuid instead
98-
- pkg: github.com/jackc/pgx3
99-
desc: Use github.com/jackc/pgx4 instead
100-
- pkg: github.com/jackc/pgx5
101-
desc: Use github.com/jackc/pgx4 instead
102-
- pkg: github.com/satori/go.uuid
103-
desc: Use github.com/google/uuid instead
104-
- pkg: github.com/test-go/testify/assert
105-
desc: Use github.com/stretchr/testify/assert instead
106-
- pkg: github.com/test-go/testify/mock
107-
desc: Use github.com/stretchr/testify/mock instead
108-
- pkg: github.com/test-go/testify/require
109-
desc: Use github.com/stretchr/testify/require instead
110-
# TODO https://smartcontract-it.atlassian.net/browse/BCI-2589
111-
# - pkg: go.uber.org/multierr
112-
# desc: Use the standard library instead, for example https://pkg.go.dev/errors#Join
113-
- pkg: gopkg.in/guregu/null.v1
114-
desc: Use gopkg.in/guregu/null.v4 instead
115-
- pkg: gopkg.in/guregu/null.v2
116-
desc: Use gopkg.in/guregu/null.v4 instead
117-
- pkg: gopkg.in/guregu/null.v3
118-
desc: Use gopkg.in/guregu/null.v4 instead
119-
- pkg: github.com/go-gorm/gorm
120-
desc: Use github.com/jmoiron/sqlx directly instead
26+
settings:
27+
depguard:
28+
rules:
29+
main:
30+
list-mode: lax
31+
deny:
32+
- pkg: cosmossdk.io/errors
33+
desc: Use the standard library instead
34+
- pkg: github.com/gofrs/uuid
35+
desc: Use github.com/google/uuid instead
36+
- pkg: github.com/jackc/pgx3
37+
desc: Use github.com/jackc/pgx4 instead
38+
- pkg: github.com/jackc/pgx5
39+
desc: Use github.com/jackc/pgx4 instead
40+
- pkg: github.com/satori/go.uuid
41+
desc: Use github.com/google/uuid instead
42+
- pkg: github.com/test-go/testify/assert
43+
desc: Use github.com/stretchr/testify/assert instead
44+
- pkg: github.com/test-go/testify/mock
45+
desc: Use github.com/stretchr/testify/mock instead
46+
- pkg: github.com/test-go/testify/require
47+
desc: Use github.com/stretchr/testify/require instead
48+
- pkg: gopkg.in/guregu/null.v1
49+
desc: Use gopkg.in/guregu/null.v4 instead
50+
- pkg: gopkg.in/guregu/null.v2
51+
desc: Use gopkg.in/guregu/null.v4 instead
52+
- pkg: gopkg.in/guregu/null.v3
53+
desc: Use gopkg.in/guregu/null.v4 instead
54+
- pkg: github.com/go-gorm/gorm
55+
desc: Use github.com/jmoiron/sqlx directly instead
56+
exhaustive:
57+
default-signifies-exhaustive: true
58+
gosec:
59+
excludes:
60+
- G101
61+
- G104
62+
govet:
63+
enable:
64+
- shadow
65+
revive:
66+
confidence: 0.8
67+
rules:
68+
- name: blank-imports
69+
- name: context-as-argument
70+
- name: context-keys-type
71+
- name: dot-imports
72+
- name: error-return
73+
- name: error-strings
74+
- name: error-naming
75+
- name: exported
76+
- name: if-return
77+
- name: increment-decrement
78+
- name: var-naming
79+
- name: var-declaration
80+
- name: package-comments
81+
- name: range
82+
- name: receiver-naming
83+
- name: time-naming
84+
- name: indent-error-flow
85+
- name: errorf
86+
- name: empty-block
87+
- name: superfluous-else
88+
- name: unreachable-code
89+
- name: redefines-builtin-id
90+
- name: waitgroup-by-value
91+
- name: unconditional-recursion
92+
- name: struct-tag
93+
- name: string-of-int
94+
- name: range-val-address
95+
- name: range-val-in-closure
96+
- name: modifies-value-receiver
97+
- name: modifies-parameter
98+
- name: identical-branches
99+
- name: get-return
100+
- name: early-return
101+
- name: defer
102+
- name: constant-logical-expr
103+
- name: bool-literal-in-expr
104+
- name: atomic
105+
exclusions:
106+
generated: lax
107+
presets:
108+
- comments
109+
- common-false-positives
110+
- legacy
111+
- std-error-handling
112+
paths:
113+
- third_party$
114+
- builtin$
115+
- examples$
116+
formatters:
117+
enable:
118+
- goimports
119+
settings:
120+
goimports:
121+
local-prefixes:
122+
- github.com/smartcontractkit/chainlink
123+
exclusions:
124+
generated: lax
125+
paths:
126+
- third_party$
127+
- builtin$
128+
- examples$

‎capabilities/writetarget/mocks/target_strategy.go‎

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎go.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ flowchart LR
1010
chainlink-common --> chainlink-common/pkg/values
1111
chainlink-common --> chainlink-protos/billing/go
1212
chainlink-common --> chainlink-protos/cre/go
13+
chainlink-common --> chainlink-protos/linking-service/go
14+
chainlink-common --> chainlink-protos/node-platform
1315
chainlink-common --> chainlink-protos/storage-service
1416
chainlink-common --> chainlink-protos/workflows/go
1517
chainlink-common --> freeport
@@ -32,6 +34,10 @@ flowchart LR
3234
click chainlink-protos/billing/go href "https://github.com/smartcontractkit/chainlink-protos"
3335
chainlink-protos/cre/go
3436
click chainlink-protos/cre/go href "https://github.com/smartcontractkit/chainlink-protos"
37+
chainlink-protos/linking-service/go
38+
click chainlink-protos/linking-service/go href "https://github.com/smartcontractkit/chainlink-protos"
39+
chainlink-protos/node-platform
40+
click chainlink-protos/node-platform href "https://github.com/smartcontractkit/chainlink-protos"
3541
chainlink-protos/storage-service
3642
click chainlink-protos/storage-service href "https://github.com/smartcontractkit/chainlink-protos"
3743
chainlink-protos/workflows/go
@@ -61,6 +67,8 @@ flowchart LR
6167
subgraph chainlink-protos-repo[chainlink-protos]
6268
chainlink-protos/billing/go
6369
chainlink-protos/cre/go
70+
chainlink-protos/linking-service/go
71+
chainlink-protos/node-platform
6472
chainlink-protos/storage-service
6573
chainlink-protos/workflows/go
6674
end

0 commit comments

Comments
 (0)