update

Author: guandali

multinode/rpc_client_base.go

@@ -17,7 +17,6 @@ var errInvalidHead = errors.New("invalid head")
 const (
 	rpcCallNameLatestBlock          = "latest_block"
 	rpcCallNameLatestFinalizedBlock = "latest_finalized_block"
-	rpcMetricsDefaultIsSendOnly     = false
 )
 
 type RPCClientBaseConfig interface {
@@ -37,6 +36,7 @@ type RPCClientBase[HEAD Head] struct {
 	log        logger.Logger
 	ctxTimeout time.Duration
 	rpcURL     string
+	isSendOnly bool
 	subsMu     sync.RWMutex
 	subs       map[Subscription]struct{}
 
@@ -65,13 +65,15 @@ func NewRPCClientBase[HEAD Head](
 	latestBlock func(ctx context.Context) (HEAD, error),
 	latestFinalizedBlock func(ctx context.Context) (HEAD, error),
 	rpcURL string,
+	isSendOnly bool,
 	rpcMetrics frameworkmetrics.RPCClientMetrics,
 ) *RPCClientBase[HEAD] {
 	base := &RPCClientBase[HEAD]{
 		cfg:                  cfg,
 		log:                  log,
 		ctxTimeout:           ctxTimeout,
 		rpcURL:               rpcURL,
+		isSendOnly:           isSendOnly,
 		latestBlock:          latestBlock,
 		latestFinalizedBlock: latestFinalizedBlock,
 		subs:                 make(map[Subscription]struct{}),
@@ -216,7 +218,7 @@ func (m *RPCClientBase[HEAD]) recordRPCRequest(ctx context.Context, callName str
 		return
 	}
 
-	m.rpcMetrics.RecordRequest(ctx, m.rpcURL, rpcMetricsDefaultIsSendOnly, callName, time.Since(startedAt), err)
+	m.rpcMetrics.RecordRequest(ctx, m.rpcURL, m.isSendOnly, callName, time.Since(startedAt), err)
 }
 
 func (m *RPCClientBase[HEAD]) OnNewHead(ctx context.Context, requestCh <-chan struct{}, head HEAD) {

multinode/rpc_client_base_test.go

@@ -68,7 +68,7 @@ func newTestRPC(t *testing.T) *testRPC {
 	}
 
 	rpc := &testRPC{}
-	rpc.RPCClientBase = NewRPCClientBase[*testHead](cfg, requestTimeout, lggr, rpc.latestBlock, rpc.latestBlock, "http://localhost:8545", nil)
+	rpc.RPCClientBase = NewRPCClientBase[*testHead](cfg, requestTimeout, lggr, rpc.latestBlock, rpc.latestBlock, "http://localhost:8545", false, nil)
 	t.Cleanup(rpc.Close)
 	return rpc
 }
@@ -163,6 +163,7 @@ func TestRPCClientBase_RecordsRPCMetrics(t *testing.T) {
 				return &testHead{blockNumber: 8}, nil
 			},
 			testURL,
+			false,
 			spy,
 		)
 
@@ -192,6 +193,7 @@ func TestRPCClientBase_RecordsRPCMetrics(t *testing.T) {
 				return nil, expectedErr
 			},
 			testURL,
+			false,
 			spy,
 		)
 
@@ -219,6 +221,7 @@ func TestRPCClientBase_RecordsRPCMetrics(t *testing.T) {
 				return &testHead{blockNumber: 8}, nil
 			},
 			testURL,
+			false,
 			spy,
 		)