Skip to content

Commit de28b86

Browse files
committed
Remove FinalizedStateCheckFailureThreshold from shared MultiNode config
Move this field out of the shared MultiNode struct to avoid imposing it on chains that don't use finalized state checking (e.g. Solana). The EVM side provides this value through its own NodePool config, and the framework's optional FinalizedStateCheckConfig interface handles the type assertion in node_lifecycle.go.
1 parent d499e3e commit de28b86

1 file changed

Lines changed: 0 additions & 15 deletions

File tree

multinode/config/config.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ type MultiNode struct {
3434
FinalityDepth *uint32
3535
FinalityTagEnabled *bool
3636
FinalizedBlockOffset *uint32
37-
38-
// Finalized State Availability Check
39-
FinalizedStateCheckFailureThreshold *uint32
4037
}
4138

4239
func (c *MultiNodeConfig) Enabled() bool {
@@ -101,13 +98,6 @@ func (c *MultiNodeConfig) FinalityTagEnabled() bool { return *c.MultiNode.Finali
10198

10299
func (c *MultiNodeConfig) FinalizedBlockOffset() uint32 { return *c.MultiNode.FinalizedBlockOffset }
103100

104-
func (c *MultiNodeConfig) FinalizedStateCheckFailureThreshold() uint32 {
105-
if c.MultiNode.FinalizedStateCheckFailureThreshold == nil {
106-
return 0
107-
}
108-
return *c.MultiNode.FinalizedStateCheckFailureThreshold
109-
}
110-
111101
func (c *MultiNodeConfig) SetFrom(f *MultiNodeConfig) {
112102
if f.MultiNode.Enabled != nil {
113103
c.MultiNode.Enabled = f.MultiNode.Enabled
@@ -164,9 +154,4 @@ func (c *MultiNodeConfig) SetFrom(f *MultiNodeConfig) {
164154
if f.MultiNode.FinalizedBlockOffset != nil {
165155
c.MultiNode.FinalizedBlockOffset = f.MultiNode.FinalizedBlockOffset
166156
}
167-
168-
// Finalized State Availability Check
169-
if f.MultiNode.FinalizedStateCheckFailureThreshold != nil {
170-
c.MultiNode.FinalizedStateCheckFailureThreshold = f.MultiNode.FinalizedStateCheckFailureThreshold
171-
}
172157
}

0 commit comments

Comments
 (0)